Add microbenchmark for core UnmanagedMemoryStream scenario #3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
commented
Oct 21, 2023
src/benchmarks/micro/libraries/System.IO/UnmanagedMemoryStreamTests.cs
Outdated
Show resolved
Hide resolved
jozkee
previously approved these changes
Jan 29, 2024
| [GlobalSetup] | ||
| public void Setup() | ||
| { | ||
| buffer = (byte*)Marshal.AllocCoTaskMem(Length); |
There was a problem hiding this comment.
Just wondering why you chose this over AllocHGlobal?
There was a problem hiding this comment.
No particular reason. Either of these two would work just fine for this test.
jozkee
reviewed
Jan 29, 2024
src/benchmarks/micro/libraries/System.IO/UnmanagedMemoryStreamTests.cs
Outdated
Show resolved
Hide resolved
cincuranet
reviewed
Jan 30, 2024
src/benchmarks/micro/libraries/System.IO/UnmanagedMemoryStreamTests.cs
Outdated
Show resolved
Hide resolved
jkotas
commented
Jan 30, 2024
src/benchmarks/micro/libraries/System.IO/UnmanagedMemoryStreamTests.cs
Outdated
Show resolved
Hide resolved
cincuranet
approved these changes
Jan 30, 2024
|
Failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to dotnet/runtime#93766