[Membership] When indirect probe fails, include intermediary's vote in suspecter list #9302
+28
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
fix/disaster-recovery/include-intermediary-silo-votes
branch
from
4988ed6 to
c8d60b0
Compare
ReubenBond
deleted the
fix/disaster-recovery/include-intermediary-silo-votes
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The membership table includes a list of votes in the
SuspectTimesfield. This is used for counting unique "fresh" votes and it is also useful for diagnostic purposes, when working out what lead to a silo being evicted.Currently, we special case the situation where:
In that case, we will unilaterally evict the silo, but we do not include the intermediary silo's vote in the membership table.
Instead, this PR adds the intermediary's vote in the
SuspectTimesfield whenever an indirect probe fails. This ensures that the intermediary's vote is counted as part of the suspecter list and removes the special case of <= 2 votes to evict (since regular vote counting will count an indirect probe as two votes: the initiator and the intermediary both cast their vote).Microsoft Reviewers: Open in CodeFlow