Fix errors reported by GitHub Semmle code analysis tools. #6374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://lgtm.com/projects/g/dotnet/orleans/?mode=list&severity=error Fix errors reported by GitHub Semmle code analysis tools: - Missing X-Frame-Options HTTP header - https://lgtm.com/rules/1506102236348/ - Using a package with a known vulnerability - https://lgtm.com/rules/1506697777412/ - Possible loss of precision - https://lgtm.com/rules/1506096756023/ Ensure Test.cmd clears the Platform environment variable (same as in Build.cmd) in case it is run on separate cmd session (eg Appveyor builds) -- x-ref: issue dotnet#69 Remove unused $outDir param from Parallel-Tests.ps1 script. Fix a few minor comment typos in scripts.
|
The first run of the Functional test suite failed with what looks like a system clock resolution / rounding edge case glitch in test case Tester.AzureUtils.Persistence.PersistenceProviderTests_Local.PersistenceProvider_Memory_FixedLatency_WriteRead Hopefully rerunning the test will get a better result next time! |
|
There are also another 222 Warnings and 34 Recommendations reported by Semmle code analysis, if anyone wants to lend a hand with some code cleanup work. |
|
Fixed: PR #6378 addresses the unrelated test glitch found when running the Functional test suite for this PR. |
sergeybykov
reviewed
Mar 3, 2020
Limit parallel test jobs to max 4, or NUMBER_OF_PROCESSORS if that is less.
|
Thank you, Jorgen! |
sergeybykov
pushed a commit
to sergeybykov/orleans
that referenced
this pull request
Apr 24, 2020
(cherry picked from commit 0a89bf3)
ReubenBond
pushed a commit
that referenced
this pull request
May 2, 2020
(cherry picked from commit 0a89bf3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lgtm.com/projects/g/dotnet/orleans/?mode=list&severity=error
Fix errors reported by GitHub Semmle code analysis tools:
Ensure Test.cmd clears the
Platformenvironment variable (same as in Build.cmd) in case it is run on separate cmd session (eg Appveyor builds)Remove unused $outDir param from Parallel-Tests.ps1 script.