Permit a task to disable MSB4181 Fixes #5203 #5207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sae42
reviewed
Mar 30, 2020
src/Utilities/Task.cs
Outdated
| /// <summary> | ||
| /// Retrieves the <see cref="IBuildEngine7" /> version of the build engine interface provided by the host. | ||
| /// </summary> | ||
| public IBuildEngine6 BuildEngine7 => (IBuildEngine7)BuildEngine; |
| @@ -197,6 +197,7 @@ public abstract partial class Task : Microsoft.Build.Framework.ITask | |||
| public Microsoft.Build.Framework.IBuildEngine4 BuildEngine4 { get { throw null; } } | |||
| public Microsoft.Build.Framework.IBuildEngine5 BuildEngine5 { get { throw null; } } | |||
| public Microsoft.Build.Framework.IBuildEngine6 BuildEngine6 { get { throw null; } } | |||
| public Microsoft.Build.Framework.IBuildEngine6 BuildEngine7 { get { throw null; } } | |||
| @@ -352,6 +352,7 @@ public abstract partial class Task : Microsoft.Build.Framework.ITask | |||
| public Microsoft.Build.Framework.IBuildEngine4 BuildEngine4 { get { throw null; } } | |||
| public Microsoft.Build.Framework.IBuildEngine5 BuildEngine5 { get { throw null; } } | |||
| public Microsoft.Build.Framework.IBuildEngine6 BuildEngine6 { get { throw null; } } | |||
| public Microsoft.Build.Framework.IBuildEngine6 BuildEngine7 { get { throw null; } } | |||
rainersigwald
requested changes
Mar 31, 2020
| /// <summary> | ||
| /// Enables or disables emitting MSB4134 to log when a task fails without logging errors | ||
| /// </summary> | ||
| public void SetEnableMSB4134(bool enableError) |
There was a problem hiding this comment.
Why is this an explicit set method rather than a setter?
There was a problem hiding this comment.
You mean a property with {get; set;}? I don't think you can access that with reflection.
There was a problem hiding this comment.
You can, with Type.GetProperty
src/Build/Resources/Strings.resx
Outdated
| @@ -1064,8 +1064,8 @@ | |||
| </comment> | |||
| </data> | |||
| <data name="TaskReturnedFalseButDidNotLogError"> | |||
| <value>MSB4132: The "{0}" task returned false but did not log an error.</value> | |||
| <comment>{StrBegin="MSB4132: "}</comment> | |||
| <value>MSB4134: The "{0}" task returned false but did not log an error.</value> | |||
There was a problem hiding this comment.
This appears to have been used, too:
MSB4134: DefaultToolsVersion cannot be set after a project has been loaded into the Engine.
That's coming entirely from the Deprecated\Engine folder, but we still shouldn't recycle.
src/Framework/IBuildEngine7.cs
Outdated
| /// </summary> | ||
| public interface IBuildEngine7 : IBuildEngine6 | ||
| { | ||
| public void SetEnableMSB4134(bool errorEnabled); |
There was a problem hiding this comment.
Don't include the error code in the name of this method. Give it a descriptive name instead, like maybe
Suggested change
| public void SetEnableMSB4134(bool errorEnabled); | |
| public void AllowFailureWithoutError(bool errorEnabled); |
?
| @@ -93,7 +93,7 @@ public void AssemblyFoldersFromConfigPlatformSpecificAssemblyFirstTest() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void AasemblyFoldersFromConfigNormalizeNetFrameworkVersion() | |||
There was a problem hiding this comment.
Please separate this into its own PR.
Forgind
changed the title
|
Team triage: we'd like to reserve |
|
@rainersigwald If this fix has to be deferred to 16.7 is there any chance of reverting the original change that caused this issue until 16.7 also? Failing that, please at least correct the error code so that it will be consistent between releases. |
Forgind
force-pushed
the
MSB4132-opt-out
branch
2 times, most recently
from
551aea7
to
583561a
Compare
rainersigwald
requested changes
Apr 28, 2020
| @@ -93,7 +93,7 @@ public void AssemblyFoldersFromConfigPlatformSpecificAssemblyFirstTest() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void AasemblyFoldersFromConfigNormalizeNetFrameworkVersion() | |||
Forgind
force-pushed
the
MSB4132-opt-out
branch
from
60177dd
to
5287c38
Compare
This adds back support for logging an error when a task returns false without logging an error. This was originally added in dotnet#4940 but was reverted because of multiple difficulties.
Forgind
force-pushed
the
MSB4132-opt-out
branch
from
5287c38
to
db1feb2
Compare
rainersigwald
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using IBuildEngine7, one can disable MSB4132 in a task.
Fixes #5203
Also fixes #2036