Add the reviewer release skill checking if the Learn article Change waves is updated - #13840
Merged
Conversation
Contributor
🔍 Skill Validator Results
Summary
Full validator output```text Found 1 skill(s) [release] 📊 release: 2,096 BPE tokens [chars/4: 2,102] (detailed ✓), 11 sections, 0 code blocks [release] ⚠ No code blocks — agents perform better with concrete snippets and commands. ✅ All checks passed (1 skill(s)) ``` |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repo’s automated review guidance so that when documentation/wiki/ChangeWaves.md changes, reviewers are prompted to ensure the corresponding public Learn article about MSBuild Change Waves is kept in sync.
Changes:
- Added a docs-sync reminder to the
reviewing-msbuild-codeskill documentation. - Added a new ChangeWave-discipline checklist item to the
expert-revieweragent guidance to verify the Learn article is updated whenChangeWaves.mdchanges.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/skills/reviewing-msbuild-code/SKILL.md | Adds a docs-sync check note pointing reviewers to the Learn article when ChangeWaves.md changes. |
| .github/agents/expert-reviewer.agent.md | Extends the ChangeWave Discipline dimension with an explicit “verify Learn article updated” rule + checklist item. |
JanProvaznik
marked this pull request as draft
May 25, 2026 11:35
JanProvaznik
requested changes
May 25, 2026
JanProvaznik
left a comment
JanProvaznik
left a comment
Member
There was a problem hiding this comment.
hm actually I don't think this should be done as part of each PR that add changewave behavior, rather as part of the release checklist. Could you add a step there and put guidance for updating the learn page to the release skill?
GangWang01
force-pushed
the
skill-doc-changewave
branch
from
June 1, 2026 08:23
23c04c1 to
56deab9
Compare
GangWang01
changed the title
JanProvaznik
approved these changes
Jun 5, 2026
JanProvaznik
marked this pull request as ready for review
June 5, 2026 14:45
JanProvaznik
enabled auto-merge (squash)
June 5, 2026 14:46
This was referenced Jun 9, 2026
This was referenced Aug 11, 2026
Bump Microsoft.Build from 18.4.0 to 18.9.6
SkylineCommunications/Skyline.DataMiner.CICD.Packages#172
Open
This was referenced Aug 17, 2026
Open
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13811
Context
To keep the Learn article sync with documentation/wiki/ChangeWaves.md, add reviewer skill to check.