Add warning MSB4280 when DOTNET_HOST_PATH is set to a directory#13091
Merged
JanProvaznik merged 8 commits intomainfrom Jan 23, 2026
Merged
Add warning MSB4280 when DOTNET_HOST_PATH is set to a directory#13091JanProvaznik merged 8 commits intomainfrom
JanProvaznik merged 8 commits intomainfrom
Conversation
Contributor
|
Hello @@copilot, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add warning for incorrect DOTNET_HOST_PATH usage in MSBuild
Add warning MSB4280 when DOTNET_HOST_PATH is set to a directory
Jan 22, 2026
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
Co-authored-by: JanProvaznik <25267098+JanProvaznik@users.noreply.github.com>
This was referenced Mar 16, 2026
Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core
iwizsophy/resolution-guard-nuget#6
Closed
github-actions bot
pushed a commit
to IntelliTect/Multitool
that referenced
this pull request
Mar 16, 2026
Updated [Microsoft.Build](https://github.com/dotnet/msbuild) from 18.3.3 to 18.4.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Build's releases](https://github.com/dotnet/msbuild/releases)._ ## 18.4.0 ## What's Changed * Fix terminal logger quiet mode to show project context for warnings/errors by @Copilot in dotnet/msbuild#12930 * Replace OpenTelemetry with Microsoft.VisualStudio.Telemetry for VS by @YuliiaKovalova in dotnet/msbuild#12843 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13050856 by @dotnet-bot in dotnet/msbuild#12982 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#12979 * eliminate test data serialization warnings by @JanProvaznik in dotnet/msbuild#12983 * Add the feature flag that allows users to opt out automatic UTF8 console encoding by @GangWang01 in dotnet/msbuild#12637 * Polyfill clean up and source package organization by @DustinCampbell in dotnet/msbuild#12977 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13052367 by @dotnet-bot in dotnet/msbuild#12984 * Add documentation for enabling binlog collection via env var by @YuliiaKovalova in dotnet/msbuild#12805 * Support multiple binary logs from command line arguments by @Copilot in dotnet/msbuild#12706 * Add VcxprojReader.exe to ngenApplications by @YuliiaKovalova in dotnet/msbuild#12986 * Add HostServices support in Out-of-Process Task Host by @YuliiaKovalova in dotnet/msbuild#12753 * [main] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/msbuild#13002 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/msbuild#13000 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13078382 by @dotnet-bot in dotnet/msbuild#13003 * Add telemetry tracking for task factory names and runtime usage by @Copilot in dotnet/msbuild#12989 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#12987 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13079827 by @dotnet-bot in dotnet/msbuild#13010 * Snap for VS 18.3 and update branding to VS 18.4 by @Copilot in dotnet/msbuild#13005 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#13012 * Add telemetry to categorize build failure reasons by @Copilot in dotnet/msbuild#13007 * Update MicrosoftBuildVersion in analyzer template by @github-actions[bot] in dotnet/msbuild#13011 * Update OptProf drop metadata configuration by @YuliiaKovalova in dotnet/msbuild#13020 * Fix MSB1025 error when using DistributedFileLogger (-dfl flag) by @Copilot in dotnet/msbuild#13036 * CmdLine parsing was extracted from XMake and the implementation is visible to dotnet (attempt 2) by @MichalPavlik in dotnet/msbuild#12836 * Make task environment path absolutization not throw. by @AR-May in dotnet/msbuild#13035 * Fix flaky test TestTerminalLoggerTogetherWithOtherLoggers by @Copilot in dotnet/msbuild#13044 * Enlighten more tasks that require no change by @AR-May in dotnet/msbuild#13045 * [main] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/msbuild#13050 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/msbuild#13048 * Add support for MSBUILD_LOGGING_ARGS by @YuliiaKovalova in dotnet/msbuild#12993 * Fix MSBuildEventSource by @dfederm in dotnet/msbuild#13030 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13124182 by @dotnet-bot in dotnet/msbuild#13053 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#13031 * Add incrementality tracking support and more detailed analysis of the build errors reported by @YuliiaKovalova in dotnet/msbuild#13057 * [automated] Merge branch 'vs18.3' => 'main' by @github-actions[bot] in dotnet/msbuild#13055 * Enable com support for clr4 in task host by @YuliiaKovalova in dotnet/msbuild#13033 * Add 'rel/d18.3' to insertion target branch options by @ViktorHofer in dotnet/msbuild#13067 * add OriginalValue property to AbsolutePath by @JanProvaznik in dotnet/msbuild#13077 * [automated] Merge branch 'vs18.3' => 'main' by @github-actions[bot] in dotnet/msbuild#13074 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13137486 by @dotnet-bot in dotnet/msbuild#13075 * Refactor FileUtilities.cs and add methods for absolute paths. by @AR-May in dotnet/msbuild#13079 * Limit extended flag usage to NET and CLR4 runtimes by @YuliiaKovalova in dotnet/msbuild#13080 * [main] Update dependencies from nuget/nuget.client by @dotnet-maestro[bot] in dotnet/msbuild#13065 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13137926 by @dotnet-bot in dotnet/msbuild#13081 * Update to 10.0.1 references by @rainersigwald in dotnet/msbuild#13072 * Undo COM support in out of proc task host CLR4 by @YuliiaKovalova in dotnet/msbuild#13089 * Add Managed Identity for bootstrapper creation by @rainersigwald in dotnet/msbuild#13092 * Add warning MSB4280 when DOTNET_HOST_PATH is set to a directory by @Copilot in dotnet/msbuild#13091 ... (truncated) Commits viewable in [compare view](dotnet/msbuild@v18.3.3...v18.4.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 16, 2026
Closed
premun
pushed a commit
to sharpliner/sharpliner
that referenced
this pull request
Mar 16, 2026
Updated [Microsoft.Build.Framework](https://github.com/dotnet/msbuild) from 18.3.3 to 18.4.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Build.Framework's releases](https://github.com/dotnet/msbuild/releases)._ ## 18.4.0 ## What's Changed * Fix terminal logger quiet mode to show project context for warnings/errors by @Copilot in dotnet/msbuild#12930 * Replace OpenTelemetry with Microsoft.VisualStudio.Telemetry for VS by @YuliiaKovalova in dotnet/msbuild#12843 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13050856 by @dotnet-bot in dotnet/msbuild#12982 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#12979 * eliminate test data serialization warnings by @JanProvaznik in dotnet/msbuild#12983 * Add the feature flag that allows users to opt out automatic UTF8 console encoding by @GangWang01 in dotnet/msbuild#12637 * Polyfill clean up and source package organization by @DustinCampbell in dotnet/msbuild#12977 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13052367 by @dotnet-bot in dotnet/msbuild#12984 * Add documentation for enabling binlog collection via env var by @YuliiaKovalova in dotnet/msbuild#12805 * Support multiple binary logs from command line arguments by @Copilot in dotnet/msbuild#12706 * Add VcxprojReader.exe to ngenApplications by @YuliiaKovalova in dotnet/msbuild#12986 * Add HostServices support in Out-of-Process Task Host by @YuliiaKovalova in dotnet/msbuild#12753 * [main] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/msbuild#13002 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/msbuild#13000 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13078382 by @dotnet-bot in dotnet/msbuild#13003 * Add telemetry tracking for task factory names and runtime usage by @Copilot in dotnet/msbuild#12989 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#12987 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13079827 by @dotnet-bot in dotnet/msbuild#13010 * Snap for VS 18.3 and update branding to VS 18.4 by @Copilot in dotnet/msbuild#13005 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#13012 * Add telemetry to categorize build failure reasons by @Copilot in dotnet/msbuild#13007 * Update MicrosoftBuildVersion in analyzer template by @github-actions[bot] in dotnet/msbuild#13011 * Update OptProf drop metadata configuration by @YuliiaKovalova in dotnet/msbuild#13020 * Fix MSB1025 error when using DistributedFileLogger (-dfl flag) by @Copilot in dotnet/msbuild#13036 * CmdLine parsing was extracted from XMake and the implementation is visible to dotnet (attempt 2) by @MichalPavlik in dotnet/msbuild#12836 * Make task environment path absolutization not throw. by @AR-May in dotnet/msbuild#13035 * Fix flaky test TestTerminalLoggerTogetherWithOtherLoggers by @Copilot in dotnet/msbuild#13044 * Enlighten more tasks that require no change by @AR-May in dotnet/msbuild#13045 * [main] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/msbuild#13050 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/msbuild#13048 * Add support for MSBUILD_LOGGING_ARGS by @YuliiaKovalova in dotnet/msbuild#12993 * Fix MSBuildEventSource by @dfederm in dotnet/msbuild#13030 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13124182 by @dotnet-bot in dotnet/msbuild#13053 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#13031 * Add incrementality tracking support and more detailed analysis of the build errors reported by @YuliiaKovalova in dotnet/msbuild#13057 * [automated] Merge branch 'vs18.3' => 'main' by @github-actions[bot] in dotnet/msbuild#13055 * Enable com support for clr4 in task host by @YuliiaKovalova in dotnet/msbuild#13033 * Add 'rel/d18.3' to insertion target branch options by @ViktorHofer in dotnet/msbuild#13067 * add OriginalValue property to AbsolutePath by @JanProvaznik in dotnet/msbuild#13077 * [automated] Merge branch 'vs18.3' => 'main' by @github-actions[bot] in dotnet/msbuild#13074 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13137486 by @dotnet-bot in dotnet/msbuild#13075 * Refactor FileUtilities.cs and add methods for absolute paths. by @AR-May in dotnet/msbuild#13079 * Limit extended flag usage to NET and CLR4 runtimes by @YuliiaKovalova in dotnet/msbuild#13080 * [main] Update dependencies from nuget/nuget.client by @dotnet-maestro[bot] in dotnet/msbuild#13065 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13137926 by @dotnet-bot in dotnet/msbuild#13081 * Update to 10.0.1 references by @rainersigwald in dotnet/msbuild#13072 * Undo COM support in out of proc task host CLR4 by @YuliiaKovalova in dotnet/msbuild#13089 * Add Managed Identity for bootstrapper creation by @rainersigwald in dotnet/msbuild#13092 * Add warning MSB4280 when DOTNET_HOST_PATH is set to a directory by @Copilot in dotnet/msbuild#13091 ... (truncated) Commits viewable in [compare view](dotnet/msbuild@v18.3.3...v18.4.0). </details> Updated [Microsoft.Build.Utilities.Core](https://github.com/dotnet/msbuild) from 18.3.3 to 18.4.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.Build.Utilities.Core's releases](https://github.com/dotnet/msbuild/releases)._ ## 18.4.0 ## What's Changed * Fix terminal logger quiet mode to show project context for warnings/errors by @Copilot in dotnet/msbuild#12930 * Replace OpenTelemetry with Microsoft.VisualStudio.Telemetry for VS by @YuliiaKovalova in dotnet/msbuild#12843 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13050856 by @dotnet-bot in dotnet/msbuild#12982 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#12979 * eliminate test data serialization warnings by @JanProvaznik in dotnet/msbuild#12983 * Add the feature flag that allows users to opt out automatic UTF8 console encoding by @GangWang01 in dotnet/msbuild#12637 * Polyfill clean up and source package organization by @DustinCampbell in dotnet/msbuild#12977 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13052367 by @dotnet-bot in dotnet/msbuild#12984 * Add documentation for enabling binlog collection via env var by @YuliiaKovalova in dotnet/msbuild#12805 * Support multiple binary logs from command line arguments by @Copilot in dotnet/msbuild#12706 * Add VcxprojReader.exe to ngenApplications by @YuliiaKovalova in dotnet/msbuild#12986 * Add HostServices support in Out-of-Process Task Host by @YuliiaKovalova in dotnet/msbuild#12753 * [main] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/msbuild#13002 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/msbuild#13000 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13078382 by @dotnet-bot in dotnet/msbuild#13003 * Add telemetry tracking for task factory names and runtime usage by @Copilot in dotnet/msbuild#12989 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#12987 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13079827 by @dotnet-bot in dotnet/msbuild#13010 * Snap for VS 18.3 and update branding to VS 18.4 by @Copilot in dotnet/msbuild#13005 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#13012 * Add telemetry to categorize build failure reasons by @Copilot in dotnet/msbuild#13007 * Update MicrosoftBuildVersion in analyzer template by @github-actions[bot] in dotnet/msbuild#13011 * Update OptProf drop metadata configuration by @YuliiaKovalova in dotnet/msbuild#13020 * Fix MSB1025 error when using DistributedFileLogger (-dfl flag) by @Copilot in dotnet/msbuild#13036 * CmdLine parsing was extracted from XMake and the implementation is visible to dotnet (attempt 2) by @MichalPavlik in dotnet/msbuild#12836 * Make task environment path absolutization not throw. by @AR-May in dotnet/msbuild#13035 * Fix flaky test TestTerminalLoggerTogetherWithOtherLoggers by @Copilot in dotnet/msbuild#13044 * Enlighten more tasks that require no change by @AR-May in dotnet/msbuild#13045 * [main] Update dependencies from dotnet/roslyn by @dotnet-maestro[bot] in dotnet/msbuild#13050 * [main] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/msbuild#13048 * Add support for MSBUILD_LOGGING_ARGS by @YuliiaKovalova in dotnet/msbuild#12993 * Fix MSBuildEventSource by @dfederm in dotnet/msbuild#13030 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13124182 by @dotnet-bot in dotnet/msbuild#13053 * [main] Source code updates from dotnet/dotnet by @dotnet-maestro[bot] in dotnet/msbuild#13031 * Add incrementality tracking support and more detailed analysis of the build errors reported by @YuliiaKovalova in dotnet/msbuild#13057 * [automated] Merge branch 'vs18.3' => 'main' by @github-actions[bot] in dotnet/msbuild#13055 * Enable com support for clr4 in task host by @YuliiaKovalova in dotnet/msbuild#13033 * Add 'rel/d18.3' to insertion target branch options by @ViktorHofer in dotnet/msbuild#13067 * add OriginalValue property to AbsolutePath by @JanProvaznik in dotnet/msbuild#13077 * [automated] Merge branch 'vs18.3' => 'main' by @github-actions[bot] in dotnet/msbuild#13074 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13137486 by @dotnet-bot in dotnet/msbuild#13075 * Refactor FileUtilities.cs and add methods for absolute paths. by @AR-May in dotnet/msbuild#13079 * Limit extended flag usage to NET and CLR4 runtimes by @YuliiaKovalova in dotnet/msbuild#13080 * [main] Update dependencies from nuget/nuget.client by @dotnet-maestro[bot] in dotnet/msbuild#13065 * Localized file check-in by OneLocBuild Task: Build definition ID 9434: Build ID 13137926 by @dotnet-bot in dotnet/msbuild#13081 * Update to 10.0.1 references by @rainersigwald in dotnet/msbuild#13072 * Undo COM support in out of proc task host CLR4 by @YuliiaKovalova in dotnet/msbuild#13089 * Add Managed Identity for bootstrapper creation by @rainersigwald in dotnet/msbuild#13092 * Add warning MSB4280 when DOTNET_HOST_PATH is set to a directory by @Copilot in dotnet/msbuild#13091 ... (truncated) Commits viewable in [compare view](dotnet/msbuild@v18.3.3...v18.4.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Mar 16, 2026
This was referenced Mar 24, 2026
Open
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Roslyn build tasks and other SDK tools rely on
DOTNET_HOST_PATHto locate the dotnet executable. When users set this variable to a directory path instead of a file path, builds fail with unhelpful error messages, making root cause difficult to identify.Changes Made
MSB4280inBuildManager.BeginBuildthat fires whenDOTNET_HOST_PATHpoints to a directoryExceptionHandling.IsIoRelatedException()pattern for graceful failure when checking the pathEnvironmentVariableValidator.csinsrc/Build/BackEnd/BuildManager/to centralize environment variable validation logic:ValidateEnvironmentVariables(ILoggingService)called from BuildManagerValidateDotnetHostPath)Example output:
Testing
DotnetHostPathDirectoryWarning: verifies warning when path is directoryDotnetHostPathFileNoWarning: verifies no warning when path is fileDotnetHostPathNotSetNoWarning: verifies no warning when unsetTests use shared test infrastructure (
_env,_buildManager,_parameters,_logger) for concise implementation.Notes
Validation uses
FileSystems.Default.DirectoryExists()to detect directories without introducing new filesystem abstractions. I/O exceptions are silently ignored since this validation is best-effort and should not cause build failures if the path cannot be checked.The
EnvironmentVariableValidatorarchitecture is intentionally separate from theTraitsclass because:ILoggingServiceaccessILoggingServicewhich is only available in the Build projectOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.