Revert "Smaller thread stack size for copy threads"#12626
Merged
YuliiaKovalova merged 1 commit intomainfrom Oct 10, 2025
Merged
Revert "Smaller thread stack size for copy threads"#12626YuliiaKovalova merged 1 commit intomainfrom
YuliiaKovalova merged 1 commit intomainfrom
Conversation
This reverts commit 27d132d.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts a previous optimization that reduced thread stack size for copy threads from the default to 64KB. The revert was necessary due to stack overflow issues that were internally reported, indicating the smaller stack size was causing stability problems that outweighed any potential performance benefits.
Key Changes:
- Removes the explicit 64KB stack size specification for parallel copy threads
- Returns to using the default thread stack size
- Eliminates the associated code comment explaining the stack size optimization
YuliiaKovalova
approved these changes
Oct 9, 2025
AR-May
approved these changes
Oct 9, 2025
This was referenced Feb 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #12065
internally reported stack overflow was hit for disputable benefit