Skip to content

Final branding for 18.0#12593

Merged
rainersigwald merged 4 commits intodotnet:vs18.0from
AR-May:final-branding-18.0
Oct 3, 2025
Merged

Final branding for 18.0#12593
rainersigwald merged 4 commits intodotnet:vs18.0from
AR-May:final-branding-18.0

Conversation

@AR-May
Copy link
Member

@AR-May AR-May commented Oct 2, 2025

No description provided.

@AR-May AR-May requested a review from a team as a code owner October 2, 2025 09:03
Copilot AI review requested due to automatic review settings October 2, 2025 09:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the MSBuild version configuration to mark version 18.0.0 as a final release version. The change sets the DotNetFinalVersionKind property to "release", indicating this is no longer a preview or pre-release version.

Key Changes

  • Sets the final version kind to "release" for MSBuild 18.0.0

@JanProvaznik
Copy link
Member

@AR-May do we have darc and insertions set up correctly? so when we merge we can get a valid insertion.

@JanProvaznik
Copy link
Member

oh I checked and we don't https://github.com/dotnet/msbuild/blob/vs18.0/azure-pipelines/vs-insertion.yml
not sure if it should be a separate pr or here it's fine

@AR-May
Copy link
Member Author

AR-May commented Oct 2, 2025

Thank you, @JanProvaznik, I am looking at that now! Darc is set but the insertions not, so I will add them to this PR.

Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants