Report line number in app.config error#12535
Merged
rainersigwald merged 2 commits intodotnet:mainfrom Sep 30, 2025
Merged
Conversation
Example outputs with two intentionally misaligned versions: ``` S:\msbuild\src\MSBuild\app.config(36): error : Binding redirect for 'Microsoft.Bcl.AsyncInterfaces' redirects to a different version (9.0.0.123) than MSBuild ships (9.0.0.9). [S:\msbuild\src\MSBuild\MSBuild.csproj::TargetFramework=net472] S:\msbuild\src\MSBuild\app.amd64.config(203): error : Binding redirect for 'System.Reflection.Metadata' redirects to a different version (9.0.0.18) than MSBuild ships (9.0.0.9). [S:\msbuild\src\MSBuild\MSBuild.csproj::TargetFramework=net472] ```
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances error reporting by adding line number information to binding redirect validation errors in the MSBuild package dependency version checker. Previously, errors only included the assembly name and version mismatch details, making it difficult to locate the problematic configuration in app.config files.
Key changes:
- Enhanced error messages to include file path and line number for easier troubleshooting
- Replaced XmlDocument parsing with XmlReader to capture line information
- Changed AppConfig parameter from string to ITaskItem for better metadata access
YuliiaKovalova
approved these changes
Sep 30, 2025
JanProvaznik
approved these changes
Sep 30, 2025
This was referenced Feb 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example outputs with two intentionally misaligned versions:
This came up when working on a runtime-library version bump; the errors nicely broke the build but the fix could have been easier.