Skip to content

Conversation

@benhopkinstech
Copy link

Updated xcopy-msbuild in global.json to the latest available version on dotnet-eng

I am raising this as I made the change in aspnetcore via dotnet/aspnetcore#60666 and spotted this repository was using the previous version also

@benhopkinstech benhopkinstech requested a review from a team as a code owner March 1, 2025 21:16
@benhopkinstech
Copy link
Author

@rainersigwald / @JanKrivanek / @YuliiaKovalova

Could one of you provide a review on this?

@rainersigwald
Copy link
Member

@benhopkinstech What's motivating this? Unless we need to update I don't think we should.

@benhopkinstech
Copy link
Author

@rainersigwald

There was an issue in aspnetcore related to not meeting the minimum required version.

I then went across all the repos in the dotnet org that were using this and raised a PR to update to the latest for consistency.

If you don't think it is required, feel free to close this off :)

@rainersigwald
Copy link
Member

Got it. Yeah, in general we shouldn't need to bump this until an Arcade update triggers it--this repo doesn't use that copy of MSBuild as part of its core build process. Thanks!

@benhopkinstech
Copy link
Author

@rainersigwald

This reference is one that doesn't get updated automatically.

You can see in these two pull requests from the last two version bumps of this #10602 and #11113.

It seems it eventually causes some errors over time not sticking with the latest but it also makes sense if you only want to update it as and when it is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants