You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
I know we also have some issues that have the error "Node # has exited unexpectedly", could a bit more information on the nodes help with that one too?
I know we also have some issues that have the error "Node # has exited unexpectedly", could a bit more information on the nodes help with that one too?
Tho goal of this PR is to help collect more relevant data with perfWatson on VS hangs - as important context might be in running out-of-proc MSBuild nodes, for which we are missing dumps.
If the node process crashes - then dump is already automatically collected.
So I feel there is no other information we can add here for the crashing nodes. But kick me harder if I'm missing something specific you have on mind :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11051
Context
For various hangs detection we need worker processes dumps. Let's unblock VS perf team in enabling automatic collection of worker processes dumps.
Testing
No tests provided.
This is best effort, point in time functionality, that should be used so
FYI @davkean