Fix property expander when comparing between non-numeric and numeric properties #10696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

YuliiaKovalova merged 1 commit into dotnet:main from JaynieBai:dev/jennybai/bug10583

Oct 2, 2024

Member

JaynieBai commented Sep 24, 2024 •

edited

Loading

Fixes #10583

Context

Can't evaluate

    <PropertyGroup>
      <Foo>Foo</Foo>

      <!-- This has to be numeric. -->
      <Bar>1234</Bar>

      <!-- This is a workaround. -->
      <Good>$([System.String]::Equals($(Foo), $(Bar)))</Good>

      <!-- This works on .NET 7 but on 8 it doesn't. -->
      <Bad>$(Foo.Equals($(Bar)))</Bad>
    </PropertyGroup>

Changes Made

Use the double.TryParse instead of the convert method

Testing

Add the test cases in the test method Medley()

Notes


          Fix property expander when lsh is string

e0219d8

JaynieBai marked this pull request as ready for review

September 24, 2024 10:31

JaynieBai requested a review from maridematte

September 25, 2024 06:48

JanKrivanek approved these changes

Sep 26, 2024

View reviewed changes

YuliiaKovalova approved these changes

Oct 2, 2024

View reviewed changes

YuliiaKovalova merged commit eb8e324 into dotnet:main

Oct 2, 2024

JaynieBai mentioned this pull request

Oct 30, 2024

Add error test for property expander #10631

Closed

This was referenced Jul 28, 2025

Bump Microsoft.Build.Tasks.Core and 4 others dendrodocs/dotnet-client-lib#16

Closed

Bump BenchmarkDotNet, HtmlAgilityPack and Microsoft.Build.Tasks.Core MjrTom/AngleSharp#18

Merged

Bump coverlet.collector and 8 others G-Research/NuGetPackageChecker#83

Closed

Bump Microsoft.Build.Tasks.Core and 5 others Kiryuumaru/ApplicationBuilderHelpers#128

Closed

Bump AbsolutePathHelpers and 6 others Kiryuumaru/ApplicationBuilderHelpers#130

Closed

chore: Bump coverlet.collector and 10 others AlchemyLaboratory/ToolBox#4

Open

Bump BenchmarkDotNet and 12 others wangyum/avro#334

Open

Bump Microsoft.Build.Tasks.Core and 4 others dendrodocs/dotnet-client-lib#17

Open

This was referenced Aug 4, 2025

Bump Microsoft.Build.Tasks.Core and 3 others devlooped/json#104

Open

Bump coverlet.collector and 8 others G-Research/NuGetPackageChecker#84

Open

chore: Bump Microsoft.Build.Framework to 17.14.8 AlchemyLaboratory/ToolBox#6

Closed

chore: Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core AlchemyLaboratory/ToolBox#7

Open

This was referenced Aug 15, 2025

Bump Microsoft.Build.Utilities.Core from 15.9.20 to 17.14.8 rajkumar-rangaraj/opentelemetry-dotnet-instrumentation#1037

Closed

Bump Microsoft.Build and Microsoft.Build.Framework Ronel0810/Ruby_bot#60

Open

Bump Microsoft.Build.Framework from 17.12.6 to 17.14.8 Ronel0810/Ruby_bot#61

Closed

Bump Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core Ronel0810/Ruby_bot#62

Open

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core Ronel0810/Ruby_bot#63

Open

Bump Microsoft.Build.Framework from 17.8.3 to 17.14.8 wangyum/avro#343

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core wangyum/avro#344

Closed

Bump Microsoft.Build.Framework from 17.8.3 to 17.14.8 wangyum/avro#358

Closed

Bump Microsoft.Build.Tasks.Core from 17.11.31 to 17.14.8 dendrodocs/dotnet-client-lib#18

Closed

Bump Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core devlooped/json#106

Open

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core dotTrench/dotnet-proj-diff#43

Open

This was referenced Nov 13, 2025

Bump Microsoft.Build.Utilities.Core from 17.11.48 to 18.0.2 microsoft/sbom-tool#1318

Open

Bump Microsoft.Build.Framework from 16.5.0 to 18.0.2 sundews/Sundew.Xaml.Optimizer.BuildTask#11

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core sundews/Sundew.Xaml.Optimizer.BuildTask#12

Open

Bump Microsoft.Build.Framework from 16.5.0 to 18.0.2 sundews/Sundew.Xaml.Optimizer.BuildTask#14

Open

Bump Microsoft.Build.Framework from 17.8.3 to 18.0.2 wangyum/avro#419

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core wangyum/avro#420

Open

Bump Microsoft.Build.Framework from 17.2.0 to 18.0.2 ionide/FSharp.Analyzers.SDK#274

Closed

Bump Microsoft.Build.Framework from 17.11.48 to 18.0.2 dotTrench/dotnet-proj-diff#63

Open

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core huoshan12345/ILAccess.Fody#38

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core huoshan12345/ILAccess.Fody#42

Closed

Bump Microsoft.Build.Utilities.Core from 15.9.20 to 18.0.2 rajkumar-rangaraj/opentelemetry-dotnet-instrumentation#1105

Open

This was referenced Nov 20, 2025

Bump Microsoft.Build.Framework from 17.12.6 to 18.0.2 ac-ankitnain/dependabot-core#16

Open

Bump Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core ac-ankitnain/dependabot-core#18

Open

Bump Microsoft.Build.Framework from 17.12.6 to 18.0.2 test-org-for-perm/dependabot-core-2#24

Open

Bump Microsoft.Build.Tasks.Core and Microsoft.Build.Utilities.Core test-org-for-perm/dependabot-core-2#25

Open

Bump Microsoft.Build.Framework from 17.8.43 to 18.0.2 apache/avro#3564

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core apache/avro#3565

Merged

Bump Microsoft.Build.Framework from 17.12.6 to 18.0.2 Zastai/Zastai.Build.ApiReference#87

Closed

Bump Microsoft.Build.Framework from 17.8.43 to 18.0.2 apache/avro#3577

Closed

Bump Microsoft.Build.Framework from 17.8.3 to 18.0.2 wangyum/avro#426

Open

Bump Microsoft.Build.Framework from 17.12.50 to 17.14.28 Zastai/Zastai.Build.ApiReference#93

Closed

Bump Microsoft.Build.Framework and Microsoft.Build.Utilities.Core huoshan12345/ILAccess.Fody#46

Closed

deps: Bump the all-dependencies group with 18 updates ministryofjustice/CFO-ExternalDataIntegrationSystem#25

Closed

This was referenced Nov 28, 2025

deps: Bump the all-dependencies group with 11 updates ministryofjustice/CFO-ExternalDataIntegrationSystem#44

Closed

Bump Microsoft.Build from 17.10.46 to 18.0.2 ricardoboss/PubNet#49

Closed

Bump Microsoft.Build from 17.8.43 to 17.14.28 heroku/dotnet-getting-started#90

Merged

Bump Microsoft.Build from 17.7.2 to 18.0.2 Meir017/dotnet-logging-tools#165

Merged

Bump Microsoft.Build.Framework from 17.11.31 to 18.0.2 ATrefzer/CSharpCodeAnalyst#50

Open

Bump Microsoft.Build.Tasks.Core from 17.11.48 to 18.0.2 MjrTom/AngleSharp#47

Merged

Bump BenchmarkDotNet and 4 others leonardochaia/dotnet-affected#131

Open

Labels

None yet

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix property expander when comparing between non-numeric and numeric properties #10696

Fix property expander when comparing between non-numeric and numeric properties #10696

Uh oh!

JaynieBai commented Sep 24, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix property expander when comparing between non-numeric and numeric properties #10696

Fix property expander when comparing between non-numeric and numeric properties #10696

Uh oh!

Conversation

JaynieBai commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

Changes Made

Testing

Notes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JaynieBai commented Sep 24, 2024 •

edited

Loading