CA1835 Prefer the 'Memory'-based overloads for 'ReadAsync' and 'Write… (#7184)

* CA1835 Prefer the 'Memory'-based overloads for 'ReadAsync' and 'WriteAsync'

* Update src/Shared/CommunicationsUtilities.cs

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>

* Revert CodeAnalysis.ruleset

* enable warning on CA1835

Co-authored-by: Sam Harwell <sam@tunnelvisionlabs.com>

Author: elachlan

eng/Common.globalconfig

@@ -310,7 +310,7 @@ dotnet_diagnostic.CA1833.severity = warning
 dotnet_diagnostic.CA1834.severity = suggestion
 
 # Prefer the 'Memory'-based overloads for 'ReadAsync' and 'WriteAsync'
-dotnet_diagnostic.CA1835.severity = suggestion
+dotnet_diagnostic.CA1835.severity = warning
 
 # Prefer IsEmpty over Count
 dotnet_diagnostic.CA1836.severity = suggestion

src/Shared/CommunicationsUtilities.cs

@@ -465,7 +465,7 @@ internal static async Task<int> ReadAsync(Stream stream, byte[] buffer, int byte
             int totalBytesRead = 0;
             while (totalBytesRead < bytesToRead)
             {
-                int bytesRead = await stream.ReadAsync(buffer, totalBytesRead, bytesToRead - totalBytesRead);
+                int bytesRead = await stream.ReadAsync(buffer.AsMemory(totalBytesRead, bytesToRead - totalBytesRead), CancellationToken.None);
                 if (bytesRead == 0)
                 {
                     return totalBytesRead;