Skip to content

Commit d87d14f

Browse files
committed
Minor refactoring and cleaning
1 parent 3f8212a commit d87d14f

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

src/Build/Logging/BinaryLogger/BuildEventArgsReader.cs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -946,15 +946,11 @@ private void ReadDiagnosticFields(BuildEventArgsFields fields)
946946

947947
private ExtendedDataFields? ReadExtendedDataFields()
948948
{
949-
ExtendedDataFields? fields = null;
949+
string extendedType = ReadOptionalString()!;
950+
IDictionary<string, string>? extendedMetadata = ReadStringDictionary();
951+
string? extendedData = ReadOptionalString();
950952

951-
fields = new ExtendedDataFields();
952-
953-
fields.ExtendedType = ReadOptionalString();
954-
fields.ExtendedMetadata = ReadStringDictionary();
955-
fields.ExtendedData = ReadOptionalString();
956-
957-
return fields;
953+
return new ExtendedDataFields(extendedType, extendedMetadata, extendedData);
958954
}
959955

960956
private BuildEventArgsFields ReadBuildEventArgsFields(bool readImportance = false)

src/Build/Logging/BinaryLogger/BuildEventArgsWriter.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,6 @@ private void Write(BuildMessageEventArgs e)
484484
}
485485
}
486486

487-
488487
private void Write(ProjectImportedEventArgs e)
489488
{
490489
Write(BinaryLogRecordKind.ProjectImported);
@@ -697,7 +696,7 @@ private void WriteMessageFields(BuildMessageEventArgs e, bool writeMessage = tru
697696
}
698697
}
699698

700-
private void WriteArguments(object[] arguments)
699+
private void WriteArguments(object[] arguments)
701700
{
702701
if (arguments == null || arguments.Length == 0)
703702
{

0 commit comments

Comments
 (0)