Skip to content

Commit 8777dca

Browse files
authored
Don't force shipping versions to be used in VMR builds (#11625)
Don't build MSBuild with shipping versions in the VMR unless the VMR passes an official build ID. When MSBuild is being built in the VMR, sometimes later-built packages can end up with different versions than earlier-built packages. That's not good, but it doesn't cause failures. However, these later-built packages can have different (higher) versions of dependency projects that had already been built with the lower versions. This causes downgrade failures like the following intermittently for any VMR jobs triggered around the end of the PST workday: > Detected package downgrade: Microsoft.Build.Tasks.Core from 17.15.0-ci-25175-01 to centrally defined 17.15.0-ci-25174-01. Update the centrally managed package version to a higher version. > Msbuild.Tests.Utilities -> Microsoft.Build.Runtime 17.15.0-ci-25174-01 -> Microsoft.Build.Tasks.Core (>= 17.15.0-ci-25175-01) > Msbuild.Tests.Utilities -> Microsoft.Build.Tasks.Core (>= 17.15.0-ci-25174-01)
1 parent c2c7d24 commit 8777dca

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

eng/Versions.props

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,12 @@
66
<PackageValidationBaselineVersion>17.14.0-preview-25161-14</PackageValidationBaselineVersion>
77
<AssemblyVersion>15.1.0.0</AssemblyVersion>
88
<PreReleaseVersionLabel>preview</PreReleaseVersionLabel>
9-
<DotNetUseShippingVersions>true</DotNetUseShippingVersions>
9+
<!--
10+
Don't use shipping versions when building in the VMR unless the VMR directs the build to use shipping versions.
11+
This can cause issues when building downstream repos in the orchestrated build if the time MSBuild
12+
is built crosses a UTC date boundary.
13+
-->
14+
<DotNetUseShippingVersions Condition="'$(DotNetBuildOrchestrator)' != 'true'">true</DotNetUseShippingVersions>
1015
<!-- Workaround for https://github.com/dotnet/roslyn/issues/35793 -->
1116
<SemanticVersioningV1>true</SemanticVersioningV1>
1217
<MicroBuildPluginsSwixBuildVersion>1.1.87</MicroBuildPluginsSwixBuildVersion>

0 commit comments

Comments
 (0)