Fix tests to explicitly use ConsoleLogger to prevent CI/CD logger auto-detection

Co-authored-by: baronfel <573979+baronfel@users.noreply.github.com>

Author: Copilot

src/MSBuild.UnitTests/MSBuildServer_Tests.cs

@@ -99,7 +99,7 @@ public void MSBuildServerTest()
             int pidOfServerProcess = ParseNumber(output, "Server ID is ");
             pidOfInitialProcess.ShouldNotBe(pidOfServerProcess, "We started a server node to execute the target rather than running it in-proc, so its pid should be different.");
 
-            output = RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, project.Path, out success, false, _output);
+            output = ExecMSBuildWithConsoleLogger(project.Path, out success);
             success.ShouldBeTrue();
             int newPidOfInitialProcess = ParseNumber(output, "Process ID is ");
             newPidOfInitialProcess.ShouldNotBe(pidOfServerProcess, "We started a server node to execute the target rather than running it in-proc, so its pid should be different.");
@@ -125,7 +125,7 @@ public void MSBuildServerTest()
             RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, sleepProject.Path, out _);
 
             // Ensure that a new build can still succeed and that its server node is different.
-            output = RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, project.Path, out success, false, _output);
+            output = ExecMSBuildWithConsoleLogger(project.Path, out success);
 
             success.ShouldBeTrue();
             newPidOfInitialProcess = ParseNumber(output, "Process ID is ");
@@ -152,14 +152,14 @@ public void VerifyMixedLegacyBehavior()
             pidOfInitialProcess.ShouldNotBe(pidOfServerProcess, "We started a server node to execute the target rather than running it in-proc, so its pid should be different.");
 
             Environment.SetEnvironmentVariable("MSBUILDUSESERVER", "");
-            output = RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, project.Path, out success, false, _output);
+            output = ExecMSBuildWithConsoleLogger(project.Path, out success);
             success.ShouldBeTrue();
             pidOfInitialProcess = ParseNumber(output, "Process ID is ");
             int pidOfNewserverProcess = ParseNumber(output, "Server ID is ");
             pidOfInitialProcess.ShouldBe(pidOfNewserverProcess, "We did not start a server node to execute the target, so its pid should be the same.");
 
             Environment.SetEnvironmentVariable("MSBUILDUSESERVER", "1");
-            output = RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, project.Path, out success, false, _output);
+            output = ExecMSBuildWithConsoleLogger(project.Path, out success);
             success.ShouldBeTrue();
             pidOfInitialProcess = ParseNumber(output, "Process ID is ");
             pidOfNewserverProcess = ParseNumber(output, "Server ID is ");
@@ -211,13 +211,13 @@ public void BuildsWhileBuildIsRunningOnServer()
 
             Environment.SetEnvironmentVariable("MSBUILDUSESERVER", "0");
 
-            output = RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, project.Path, out success, false, _output);
+            output = ExecMSBuildWithConsoleLogger(project.Path, out success);
             success.ShouldBeTrue();
             ParseNumber(output, "Server ID is ").ShouldBe(ParseNumber(output, "Process ID is "), "There should not be a server node for this build.");
 
             Environment.SetEnvironmentVariable("MSBUILDUSESERVER", "1");
 
-            output = RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, project.Path, out success, false, _output);
+            output = ExecMSBuildWithConsoleLogger(project.Path, out success);
             success.ShouldBeTrue();
             pidOfServerProcess.ShouldNotBe(ParseNumber(output, "Server ID is "), "The server should be otherwise occupied.");
             pidOfServerProcess.ShouldNotBe(ParseNumber(output, "Process ID is "), "There should not be a server node for this build.");
@@ -347,6 +347,14 @@ public void PropertyMSBuildStartupDirectoryOnServer()
             output.ShouldContain($@":MSBuildStartupDirectory:{Environment.CurrentDirectory}:");
         }
 
+        /// <summary>
+        /// Execute MSBuild with explicit console logger to prevent CI/CD logger auto-detection in test environments.
+        /// </summary>
+        private string ExecMSBuildWithConsoleLogger(string projectPath, out bool success)
+        {
+            return RunnerUtilities.ExecMSBuild(BuildEnvironmentHelper.Instance.CurrentMSBuildExePath, $"{projectPath} -logger:ConsoleLogger", out success, false, _output);
+        }
+
         private int ParseNumber(string searchString, string toFind)
         {
             Regex regex = new(@$"{toFind}(\d+)");

src/MSBuild.UnitTests/PerfLog_Tests.cs

@@ -40,7 +40,7 @@ public void TestPerfLogEnabledProducedLogFile()
                     ");
 
                 string projectPath = Path.Combine(projectFolder.Path, "ClassLibrary.csproj");
-                string msbuildParameters = "\"" + projectPath + "\"";
+                string msbuildParameters = "\"" + projectPath + "\" -logger:ConsoleLogger";
 
                 RunnerUtilities.ExecMSBuild(msbuildParameters, out bool successfulExit);
                 successfulExit.ShouldBeTrue();
@@ -76,7 +76,7 @@ public void TestPerfLogDirectoryGetsCreated()
                     ");
 
                 string projectPath = Path.Combine(projectFolder.Path, "ClassLibrary.csproj");
-                string msbuildParameters = "\"" + projectPath + "\"";
+                string msbuildParameters = "\"" + projectPath + "\" -logger:ConsoleLogger";
 
                 Directory.Exists(perfLogPath).ShouldBeFalse();
 

src/MSBuild.UnitTests/XMake_Tests.cs

@@ -3006,7 +3006,9 @@ private string ExecuteMSBuildExeExpectFailure(string projectContents, IDictionar
                 }
             }
 
-            string output = RunnerUtilities.ExecMSBuild($"\"{testProject.ProjectFile}\" {string.Join(" ", arguments)}", out var success, _output);
+            // Explicitly use console logger to prevent CI/CD logger auto-detection in test environments
+            string allArguments = $"\"{testProject.ProjectFile}\" -logger:ConsoleLogger {string.Join(" ", arguments)}";
+            string output = RunnerUtilities.ExecMSBuild(allArguments, out var success, _output);
 
             return (success, output);
         }