Skip to content

Commit 7816f5e

Browse files
authored
Rename liveLogger to be terminallogger (#9027)
* Rename liveLogger to be terminallogger * Keep supporting command line switches for live logger * Keep supporting MSBUILDLIVELOGGER for existing use
1 parent 59b15c1 commit 7816f5e

36 files changed

+143
-135
lines changed

documentation/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ The folder contains collection of docs and references for MSBuild, detailed info
7474
### Logging
7575

7676
* [Binary log](wiki/Binary-Log.md)
77-
* [Live logger: how to opt in](livelogger/Opt-In-Mechanism.md)
77+
* [Terminal logger: how to opt in](terminallogger/Opt-In-Mechanism.md)
7878

7979
## Archived Designs
8080
* [Resolve Assembly Reference as a service](specs/rar-as-service.md)

documentation/terminallogger/Opt-In-Mechanism.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Using the `/terminallogger` or `/tl` command line switches, users are able to op
1515

1616
### Enabling for all builds
1717

18-
Users can set the `MSBUILDLIVELOGGER` environment variable to enable TerminalLogger without adding a swtich to all build invocations.
18+
Users can set the `MSBUILDTERMINALLOGGER` environment variable to enable TerminalLogger without adding a swtich to all build invocations.
1919

2020
### TerminalLogger parameters
2121

src/Build/BackEnd/Components/Logging/LoggingService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1657,8 +1657,8 @@ private void UpdateMinimumMessageImportance(ILogger logger)
16571657
// The null logger has no effect on minimum verbosity.
16581658
Execution.BuildManager.NullLogger => null,
16591659

1660-
// The live logger consumes only high priority messages.
1661-
_ => innerLogger.GetType().FullName == "Microsoft.Build.Logging.LiveLogger.LiveLogger"
1660+
// The terminal logger consumes only high priority messages.
1661+
_ => innerLogger.GetType().FullName == "Microsoft.Build.Logging.TerminalLogger.TerminalLogger"
16621662
? MessageImportance.High
16631663
// If the logger is not on our allow list, there are no importance guarantees. Fall back to "any importance".
16641664
: MessageImportance.Low,

src/MSBuild.UnitTests/CommandLineSwitches_Tests.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,13 +167,13 @@ public void DistributedFileLoggerSwitchIdentificationTests(string distributedfil
167167
[InlineData("terminallogger")]
168168
[InlineData("TerminalLogger")]
169169
[InlineData("TERMINALLOGGER")]
170-
public void LiveLoggerSwitchIdentificationTests(string livelogger)
170+
public void TerminalLoggerSwitchIdentificationTests(string terminallogger)
171171
{
172172
CommandLineSwitches.ParameterizedSwitch parameterlessSwitch;
173173
string duplicateSwitchErrorMessage;
174174

175-
CommandLineSwitches.IsParameterizedSwitch(livelogger, out parameterlessSwitch, out duplicateSwitchErrorMessage, out bool multipleParametersAllowed, out string missingParametersErrorMessage, out bool unquoteParameters, out bool emptyParametersAllowed).ShouldBeTrue();
176-
parameterlessSwitch.ShouldBe(CommandLineSwitches.ParameterizedSwitch.LiveLogger);
175+
CommandLineSwitches.IsParameterizedSwitch(terminallogger, out parameterlessSwitch, out duplicateSwitchErrorMessage, out bool multipleParametersAllowed, out string missingParametersErrorMessage, out bool unquoteParameters, out bool emptyParametersAllowed).ShouldBeTrue();
176+
parameterlessSwitch.ShouldBe(CommandLineSwitches.ParameterizedSwitch.TerminalLogger);
177177
duplicateSwitchErrorMessage.ShouldBeNull();
178178
multipleParametersAllowed.ShouldBeTrue();
179179
missingParametersErrorMessage.ShouldBeNull();

0 commit comments

Comments
 (0)