Remove DisableDevCertSecurityCheck method in Aspire Service Defaults template #31965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed DisableDevCertSecurityCheck method and its documentation.
jfversluis
added
area-templates
There was a problem hiding this comment.
Pull Request Overview
This PR removes the DisableDevCertSecurityCheck method from the MAUI Aspire Service Defaults template to eliminate potential security risks. The method was designed to bypass certificate validation for development certificates but could introduce security vulnerabilities if used improperly.
- Removes the
DisableDevCertSecurityCheckextension method entirely - Eliminates associated XML documentation and conditional compilation attributes
- Reduces the template's attack surface by removing certificate validation bypass functionality
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this method is super useful and can only cause security risks. Let's initially remove it and if people do ask for it we'll see about it then.