Skip to content

[iOS] ToolbarItems can no longer be manipulated after an incomplete "Back" gesture on iOS - fix - #31303

Merged
jfversluis merged 1 commit into
dotnet:net10.0from
kubaflo:fix-31278
Aug 27, 2025
Merged

[iOS] ToolbarItems can no longer be manipulated after an incomplete "Back" gesture on iOS - fix#31303
jfversluis merged 1 commit into
dotnet:net10.0from
kubaflo:fix-31278

Conversation

@kubaflo

@kubaflo kubaflo commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Description of Change

Moved the CollectionChanged event handler attachment for _tracker to the initialization logic, removing redundant event handler management from WillMoveToParentViewController. This simplifies event handling and ensures the handler is consistently attached.

Issues Fixed

Fixes #31278

Moved the CollectionChanged event handler attachment for _tracker to the initialization logic, removing redundant event handler management from WillMoveToParentViewController. This simplifies event handling and ensures the handler is consistently attached.
Copilot AI review requested due to automatic review settings August 22, 2025 22:45
@kubaflo
kubaflo requested a review from a team as a code owner August 22, 2025 22:45
@kubaflo
kubaflo changed the base branch from main to net10.0 August 22, 2025 22:46
@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Aug 22, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @@kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@kubaflo kubaflo self-assigned this Aug 22, 2025
@kubaflo kubaflo changed the title Fix 31278 [iOS] ToolbarItems can no longer be manipulated after an incomplete "Back" gesture on iOS - fix Aug 22, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@PureWeen PureWeen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a uitest code this one?

@kubaflo

kubaflo commented Aug 23, 2025

Copy link
Copy Markdown
Collaborator Author

@PureWeen, I don't think we can. We couldn't figure out how to create tests with only the iOS swipe gesture, and this one would have to do only a partial swipe

@jsuarezruiz

Copy link
Copy Markdown
Contributor

@PureWeen, I don't think we can. We couldn't figure out how to create tests with only the iOS swipe gesture, and this one would have to do only a partial swipe

Could try to use the SwipeRightToLeft with a small swipe percentage:

public static void SwipeRightToLeft(this IApp app, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true)
?

@kubaflo

kubaflo commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator Author

@PureWeen, I don't think we can. We couldn't figure out how to create tests with only the iOS swipe gesture, and this one would have to do only a partial swipe

Could try to use the SwipeRightToLeft with a small swipe percentage:

public static void SwipeRightToLeft(this IApp app, double swipePercentage = 0.67, int swipeSpeed = 500, bool withInertia = true)

?

It didn't work :/

@jfversluis
jfversluis merged commit cf546bb into dotnet:net10.0 Aug 27, 2025
1 check passed
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants