[iOS/Mac]Fix StrokeDashArray Property not Rendering by devanathan-vaithiyanathan · Pull Request #29670 · dotnet/maui

devanathan-vaithiyanathan · 2025-05-26T12:06:46Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Root Cause

The IsBorderDashed() method in MauiCALayer.cs incorrectly required both a StrokeDashArray and a positive StrokeDashOffset. Since the default offset is 0, dashed borders were skipped entirely.

Description of Change

Updated the IsBorderDashed() method to only check for the existence of a dash pattern (_strokeDash), allowing dashed borders to render even when the offset is 0.

Issues Fixed

Fixes #29661

Tested the behavior in the following platforms.

Android
Windows
iOS
Mac

Output Screenshot

Before	After
iOS	iOS

jsuarezruiz · 2025-05-26T12:44:05Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-26T12:44:19Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-26T14:04:47Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29661.cs

+	public void VerifyBorderWithStrokeDashArray()
+	{
+		App.WaitForElement("StrokeDashArrayLabel");
+		VerifyScreenshot();


Pending snapshots already available in the latest build.

Could you commit the images?

@jsuarezruiz, I have added the snapshots for all platforms. Please let me know if any concerns

jsuarezruiz · 2025-05-27T06:56:53Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-27T06:57:05Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-28T06:42:25Z

src/Core/src/Platform/iOS/MauiCALayer.cs


 		bool IsBorderDashed()
 		{
-			return _strokeDash != null && _strokeDashOffset > 0;


This property determines the starting point of the dash pattern along the stroke. A negative value shifts the dash pattern in the opposite direction, which can be useful in some cases.

* fix added * Test added * snap added

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

devanathan-vaithiyanathan added 2 commits May 26, 2025 15:51

fix added

ae289c1

Test added

df1fb54

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 26, 2025

jsuarezruiz added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label May 26, 2025

jsuarezruiz added the platform/ios label May 26, 2025

jsuarezruiz suggested changes May 26, 2025

View reviewed changes

snap added

b73441f

devanathan-vaithiyanathan marked this pull request as ready for review May 27, 2025 05:57

devanathan-vaithiyanathan requested a review from a team as a code owner May 27, 2025 05:57

devanathan-vaithiyanathan requested review from rmarinho and tj-devel709 May 27, 2025 05:57

jsuarezruiz approved these changes May 28, 2025

View reviewed changes

rmarinho changed the base branch from main to inflight/current May 28, 2025 18:28

rmarinho merged commit f1d036b into dotnet:inflight/current May 28, 2025
80 checks passed

github-actions bot pushed a commit that referenced this pull request May 30, 2025

[iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670)

ae12c54

* fix added * Test added * snap added

rmarinho pushed a commit that referenced this pull request May 30, 2025

[iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670)

9a92051

* fix added * Test added * snap added

PureWeen pushed a commit that referenced this pull request Jun 3, 2025

[iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670)

0aa43b2

* fix added * Test added * snap added

HarishKumarSF4517 mentioned this pull request Jun 10, 2025

StrokeDashArray on Border does not reset when set to null #29898

Open

github-actions bot locked and limited conversation to collaborators Jun 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

[iOS/Mac]Fix StrokeDashArray Property not Rendering#29670

[iOS/Mac]Fix StrokeDashArray Property not Rendering#29670
rmarinho merged 3 commits intodotnet:inflight/currentfrom
devanathan-vaithiyanathan:fix-29661

devanathan-vaithiyanathan commented May 26, 2025

Uh oh!

jsuarezruiz commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

jsuarezruiz May 26, 2025

Uh oh!

devanathan-vaithiyanathan May 27, 2025

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

jsuarezruiz May 28, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

devanathan-vaithiyanathan commented May 26, 2025

Root Cause

Description of Change

Issues Fixed

Output Screenshot

Uh oh!

jsuarezruiz commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

jsuarezruiz May 26, 2025

Choose a reason for hiding this comment

Uh oh!

devanathan-vaithiyanathan May 27, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

jsuarezruiz May 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants