Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top by Dhivya-SF4094 · Pull Request #29632 · dotnet/maui

Dhivya-SF4094 · 2025-05-23T07:13:23Z

Note

Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!

Issue Detail

On Windows, using ItemsUpdatingScrollMode.KeepLastItemInView in CollectionView doesn't consistently scroll to the last item when new items are inserted at the top—it often stops at the second-to-last item, requiring manual scroll to view the last.

Root Cause

On Windows, when using ItemsUpdatingScrollMode.KeepLastItemInView with CollectionView, ScrollIntoView was called without specifying a scroll alignment. This caused platform-default behavior, which did not reliably bring the last item fully into view.

Description of Change

Explicitly set the ScrollIntoViewAlignment to Leading when calling ScrollIntoView. This ensures the last item is properly aligned and fully visible.

Validated the behaviour in the following platforms

Android
Windows
iOS, Mac - CarouselView Fails to Keep Last Item in View on iOS and macOS KeepLastItemInView not working on iOS #18029

Issues Fixed:

Fixes #29207

Screenshots

Before	After
29207_BeforeFix.mp4	29207_AfterFix.mp4

jsuarezruiz · 2025-05-23T11:03:28Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-23T11:03:39Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR fixes scrolling behavior for KeepLastItemInView on Windows by explicitly specifying leading alignment, and adds a UI test and sample page to validate the fix.

Explicitly use ScrollIntoViewAlignment.Leading in the Windows handler
Add a host-app sample page demonstrating the issue and fix
Introduce a UI test that taps the insert button and verifies scrolling

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/Controls/src/Core/Handlers/Items/ItemsViewHandler.Windows.cs	Added `ScrollIntoViewAlignment.Leading` to the `ScrollIntoView` call
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29207.cs	New UI test that taps the insert button and captures a screenshot
src/Controls/tests/TestCases.HostApp/Issues/Issue29207.cs	Sample `ContentPage` with a `CollectionView` and Add button to reproduce the issue

Comments suppressed due to low confidence (3)

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29207.cs:20

Relying solely on VerifyScreenshot() can lead to flaky tests. Consider asserting the presence or position of the newly added last item (e.g., with App.WaitForElement("NewItem")) to more reliably validate the scrolling behavior.

VerifyScreenshot();

src/Controls/tests/TestCases.HostApp/Issues/Issue29207.cs:60

[nitpick] The method name Button_Clicked_1 is non-descriptive and includes an index. Rename it to something like OnAddButtonClicked to clearly convey its purpose.

void Button_Clicked_1(object sender, EventArgs e)

src/Controls/tests/TestCases.HostApp/Issues/Issue29207.cs:68

[nitpick] Consider exposing ItemsSource as a public property instead of a field to align with standard MVVM and data-binding conventions.

public ObservableCollection<string> ItemsSource = new ObservableCollection<string>();

jsuarezruiz · 2025-05-26T05:55:33Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-26T05:55:44Z

Azure Pipelines successfully started running 1 pipeline(s).

jsuarezruiz · 2025-05-26T06:38:46Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29207.cs

+	{
+		App.WaitForElement("InsertItemButton");
+		App.Tap("InsertItemButton");
+		VerifyScreenshot();


Pending snapshots for Android and Windows. Running a build.

@jsuarezruiz Added the Snapshots.

jsuarezruiz · 2025-05-27T07:09:59Z

/azp run MAUI-UITests-public

azure-pipelines · 2025-05-27T07:10:10Z

Azure Pipelines successfully started running 1 pipeline(s).

…ms at Top (dotnet#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI

* Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com>

#25393) * [create-pull-request] automated change (#29793) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Convert HybridWebView.js to TypeScript and embed (#27183) * Fix up relevant CA1416 warnings - Set 3 (#26751) * [Testing] Feature Matrix UITest Cases for CollectionView Dynamic changes (#29424) * Added FeatureTests for CollectionView * changes updated * changes updated * [create-pull-request] automated change (#29505) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * CA1416 warning fix * Added snapshots * Reverting files changes * Removed the old approach * Revert unwanted changes * Reverted unwanted changes * Reverted unwanted changes * Revert unwanted changes --------- Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix up relevant CA1416 warnings - Set 1 (#26696) * Changed Syncfusion toolkit version from 1.0.4 to 1.0.5 (#29659) * [ci] Update dependencies from 9.0.4 to 9.0.5 (#29667) * [ci] Update dependencies from 9.0.4 to 9.0.5 * Update the net8 version * Add missing version MicrosoftJSInteropPackageVersion * Page.OnBackButtonPressed remove outdated API documentation (#29543) * Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top (#29632) * Fixed KeepLastItem not scrolled to last item * Updated Fix * Updated test sample * Added comment line * Updated test sample for iOS and mac * Added Snapshots for android and WinUI * Added UI tests. * Test sample changes. * script changes * script changes * Added snapshots * Resaved Mac images and the gradient image size issue has been fixed * CA1416 warning changes * Reverted unwanted changes --------- Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> * [iOS/Mac]Fix StrokeDashArray Property not Rendering (#29670) * fix added * Test added * snap added * [Android/ iOS] Fix Flyout icon is displayed when flyout is disabled (#29637) * fix added * modified the fix * test case added * test case added * summary added * Script name changed * [Android & iOS] Fix for SearchHandler Character Spacing Property (#29497) * [Android & iOS] Fix for character spacing in searchHandler * Updated test sample concerns * Update on naming * Update on formatting * Allowing updating character spacing to zero * Updated Andorid, iOS, Mac images * [create-pull-request] automated change (#29724) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [Windows] Fix for SearchHandler Visibility Not Updating During In-Section Navigation (#29441) * fix-17521-Updates the SearchHandler when navigating to another page within same ShellSection. * fix-17521-Added testcase and added snapshot for Android and iOS. * fix-17521-Renamed Shell_Navigated to OnShellNavigated. * fix-17521-Modified the Location string value from "Ethopia" to "Ethiopia". * fix-17521-Snapshot updated. * fix-17521-Updated Windows and Mac Snapshot. * [Windows] - Fix view position shift when shadows are added or removed at runtime (#29681) * Fix-view-position-shift-when-toggling-shadows * Added-Pending-SnapShots * Resaved-image * [Testing] Feature Matrix UITest Cases for Shadows (#27701) * Added sample to Matrix UITest Cases for Shadow * Renamed sample page * Renamed sample page * More tests * More tests * More tests * More tests * Added shadow tests * Updated sample * Added Windows snapshots * Updated tests * Added link to issue * More changes * Updated sample reset logic * Updated sample * More changes * More changes * More changes * Updated sample * Added snapshots * Hide cursor * More changes * More snapshots * Updated tests * Updated iOS snapshots * Updated iOS snapshots * Updated snapshots * Updated snapshots * Updated tests * [housekeeping] Automated PR to fix formatting errors on uitest-shadow-feature * Updated tests * Fix build errors * More changes * More changes * More changes * More changes --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [iOS] Fixed Shell.SearchHandler ClearPlaceholderIcon Color Issue (#28601) * SearchHandler ClearPlaceholderIcon color fix * Added Mac snapshot * Updated SearchBar Icon changes * Test script changes. * Revert unwanted changes * Updated custom icon changes * Fix -[iOS] - CarouselView Throws ArgumentOutOfRangeException Immediately on Application Launch in CV2 (#29316) * Update ItemsSourceFactory2.cs * Update CarouselViewPositionVisibility.xaml * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView (#29660) * [Windows] Fix for ItemsSource Does Not Dynamically Set to null in CarouselView * Have added test case * Updated AutomationId for better clarity and readability * Have modified the context of the description label * Have committed the snapshots * [Testing] Feature Matrix UITest Cases for Label (#29690) * Added Label Feature tests * changes updated * changes updated * changes updated * Added Screenshots * Added Snapshots for iOS * Corrected Mistakes * Added snapshots * Added images * Renamed file --------- Co-authored-by: Rui Marinho <me@ruimarinho.net> * updated base images for candidate PR failures (#29766) * [Android] Fix: Modal Animation Repeats When Returning from Background 3 (#29702) * fix * dispose listner once not needed * Revert "dispose listner once not needed" * call invalidate * add device test to check for leaks * null check and remove strong references in callback * Throw if rootview is null before adding animation * fix spelling mistake * [Testing] Include a tolerance parameter in the Verifyscreenshot method (#29776) * Added tolerance parameter to the VerifyScreenshot method * More changes * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/Controls/tests/TestCases.Shared.Tests/UITest.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * [Testing] Update Appium to v8 (#29774) * Update Appium to the latest version * Removed deprecated logic * Update comment * [create-pull-request] automated change (#29831) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Perf : ButtonContentTypeConverter now using InvariantCulture to parse double --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Tamilarasan Paranthaman <93904422+Tamilarasan-Paranthaman@users.noreply.github.com> Co-authored-by: NafeelaNazhir <nafeela.nazhirhussain@syncfusion.com> Co-authored-by: Paul Anderson <42271912+PaulAndersonS@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> Co-authored-by: Dhivya-SF4094 <127717131+Dhivya-SF4094@users.noreply.github.com> Co-authored-by: devanathan-vaithiyanathan <114395405+devanathan-vaithiyanathan@users.noreply.github.com> Co-authored-by: Subhiksha Chandrasekaran <subhiksha.c@syncfusion.com> Co-authored-by: BagavathiPerumal <93652794+BagavathiPerumal@users.noreply.github.com> Co-authored-by: prakashKannanSf3972 <127308739+prakashKannanSf3972@users.noreply.github.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: SuthiYuvaraj <92777079+SuthiYuvaraj@users.noreply.github.com> Co-authored-by: SyedAbdulAzeemSF4852 <syedabdulazeem.a@syncfusion.com> Co-authored-by: Anandhan Rajagopal <97146406+anandhan-rajagopal@users.noreply.github.com> Co-authored-by: Bhavanesh N <bhavanesh001@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>

Dhivya-SF4094 added 3 commits April 28, 2025 16:45

Fixed KeepLastItem not scrolled to last item

842a643

Updated Fix

4a0c7c7

Updated test sample

b9d4783

dotnet-policy-service bot added community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration labels May 23, 2025

sheiksyedm added platform/windows area-controls-collectionview CollectionView, CarouselView, IndicatorView labels May 23, 2025

Added comment line

5ba3009

Dhivya-SF4094 marked this pull request as ready for review May 23, 2025 11:39

Copilot AI review requested due to automatic review settings May 23, 2025 11:39

Dhivya-SF4094 requested a review from a team as a code owner May 23, 2025 11:39

Dhivya-SF4094 requested review from StephaneDelcroix and jsuarezruiz May 23, 2025 11:39

Copilot AI reviewed May 23, 2025

View reviewed changes

Updated test sample for iOS and mac

42c7826

jsuarezruiz reviewed May 26, 2025

View reviewed changes

Added Snapshots for android and WinUI

0e25391

rmarinho approved these changes May 27, 2025

View reviewed changes

rmarinho merged commit 4dc5421 into dotnet:main May 27, 2025
79 checks passed

rmarinho added this to the .NET 9 SR8 milestone May 27, 2025

github-actions bot locked and limited conversation to collaborators Jun 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top#29632

Fixed KeepLastItemInView Does Not Scroll to Last Item When Adding Items at Top#29632
rmarinho merged 6 commits intodotnet:mainfrom
Dhivya-SF4094:fix-29207

Dhivya-SF4094 commented May 23, 2025 •

edited

Loading

Uh oh!

jsuarezruiz commented May 23, 2025

Uh oh!

azure-pipelines bot commented May 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

jsuarezruiz commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

jsuarezruiz May 26, 2025

Uh oh!

Dhivya-SF4094 May 27, 2025

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

Dhivya-SF4094 commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue Detail

Root Cause

Description of Change

Validated the behaviour in the following platforms

Issues Fixed:

Screenshots

Uh oh!

jsuarezruiz commented May 23, 2025

Uh oh!

azure-pipelines bot commented May 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

jsuarezruiz commented May 26, 2025

Uh oh!

azure-pipelines bot commented May 26, 2025

Uh oh!

jsuarezruiz May 26, 2025

Choose a reason for hiding this comment

Uh oh!

Dhivya-SF4094 May 27, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented May 27, 2025

Uh oh!

azure-pipelines bot commented May 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Dhivya-SF4094 commented May 23, 2025 •

edited

Loading