[Android] Fixed ScalingCanvas.SetBlur not working#28911
Merged
PureWeen merged 2 commits intodotnet:inflight/currentfrom Apr 11, 2025
Merged
[Android] Fixed ScalingCanvas.SetBlur not working#28911PureWeen merged 2 commits intodotnet:inflight/currentfrom
PureWeen merged 2 commits intodotnet:inflight/currentfrom
Conversation
Contributor
|
Hey there @@NirmalKumarYuvaraj! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
the
partner/syncfusion
jsuarezruiz
added
the
area-drawing
jsuarezruiz
approved these changes
Apr 11, 2025
Contributor
jsuarezruiz
left a comment
jsuarezruiz
left a comment
There was a problem hiding this comment.
LGTM, just a pending reference snapshot on Windows for the added test. Can retarget to the inflight branch?
| public void CanvasShouldHonorBlur() | ||
| { | ||
| App.WaitForElement("label"); | ||
| VerifyScreenshot(); |
Contributor
There was a problem hiding this comment.
Pending snapshot on Windows.
PureWeen
force-pushed
the
inflight/current
branch
from
717a197 to
be43be9
Compare
PureWeen
pushed a commit
that referenced
this pull request
Apr 16, 2025
* Fixed android blur issue * added issue link
sheiksyedm
pushed a commit
to sheiksyedm/maui
that referenced
this pull request
Apr 17, 2025
* Fixed android blur issue * added issue link
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 17, 2025
* Fixed android blur issue * added issue link
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
* Fixed android blur issue * added issue link
PureWeen
added a commit
that referenced
this pull request
Apr 23, 2025
### Description of Change ## .NET MAUI Release Notes - Inflight/Candidate ## What's Changed ### MAUI Product Fixes * Fix CarouselView layout SR6 regressions by @albyrock87 in #29035 * Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen in https://github.com/dotnet/maui/pull/1fb5164929 * [Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in #28996 * [Android] picker - focus/unfocus events by @kubaflo in #28122 * [XC] add IRootObjectProvider by @StephaneDelcroix in #28310 * [iOS] Fix for the File.ContentType from MediaPicker not being in valid MIME format by @SyedAbdulAzeemSF4852 in #28842 * [Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage by @Ahamed-Ali in #28844 * [iOS] Fix FlyoutPage does not respond to changes in the FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in #28884 * [Android] Fixed ScalingCanvas.SetBlur not working by @NirmalKumarYuvaraj in #28911 * [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in CV2 by @prakashKannanSf3972 in #28641 * [iOS] Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in #28890 * [Windows] - Fix Visual State Issue with Picker TextColor After Navigation by @prakashKannanSf3972 in #28746 ### Dependency Updates * [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in #28499 ### Testing * [Testing] Feature Matrix UITest Cases for CollectionView EmptyView Feature by @NafeelaNazhir in #28679 * Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by @HarishKumarSF4517 in #29049 **Full Changelog**: main...inflight/candidate For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issue of
ScalingCanvas.SetBlurnot working on Android, adds a corresponding test case, and implements the necessary interface changes.RootCause
The _blurrableCanvas is null at the time of updating the blur. As a result the blur is not updated to the PlatformCanvas.
Description of Change
src/Graphics/src/Graphics/Platforms/Android/PlatformCanvas.cs: Implemented theIBlurrableCanvasinterface in thePlatformCanvasclass to support the blur functionality.Reference:
maui/src/Graphics/src/Graphics/Platforms/Windows/PlatformCanvas.cs
Lines 28 to 31 in 2cc5a76
Issues Fixed
Fixes #8632
Validated the behaviour in the following platforms
Output