[iOS] Fix for the File.ContentType from MediaPicker not being in valid MIME format#28842
Merged
PureWeen merged 4 commits intodotnet:inflight/currentfrom Apr 11, 2025
Merged
Conversation
Contributor
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
Stumbled upon this issue and now this PR once again and wanted to adapt this solution myself. I noticed that UTType is only supported starting with iOS 14.0. So this solution would crash on iOS versions <14.0. |
MartyIX
reviewed
Apr 9, 2025
MartyIX
reviewed
Apr 9, 2025
Member
|
@SyedAbdulAzeemSF4852 why is this still a draft? |
jfversluis
approved these changes
Apr 10, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Essentials/test/DeviceTests/Tests/FileSystem_Tests.cs:57
- [nitpick] Consider wrapping the file deletion in a try-finally block to ensure the temporary file is always removed even if an assertion fails.
File.Delete(filePath);
PureWeen
pushed a commit
that referenced
this pull request
Apr 16, 2025
…d MIME format (#28842) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format ). * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format )
sheiksyedm
pushed a commit
to sheiksyedm/maui
that referenced
this pull request
Apr 17, 2025
…d MIME format (dotnet#28842) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format ). * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format )
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 17, 2025
…d MIME format (dotnet#28842) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format ). * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format )
github-actions bot
pushed a commit
that referenced
this pull request
Apr 18, 2025
…d MIME format (#28842) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format ). * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 (File.ContentType from MediaPicker is not in MIME format) * [iOS] Fix for 15562 ( File.ContentType from MediaPicker is not in MIME format )
PureWeen
added a commit
that referenced
this pull request
Apr 23, 2025
### Description of Change ## .NET MAUI Release Notes - Inflight/Candidate ## What's Changed ### MAUI Product Fixes * Fix CarouselView layout SR6 regressions by @albyrock87 in #29035 * Revert "[Android] picker - focus/unfocus events (#28122)" by @PureWeen in https://github.com/dotnet/maui/pull/1fb5164929 * [Windows] Fixed the flyout content width not being set correctly after updating to WinUI SDK 1.7 by @Tamilarasan-Paranthaman in #28996 * [Android] picker - focus/unfocus events by @kubaflo in #28122 * [XC] add IRootObjectProvider by @StephaneDelcroix in #28310 * [iOS] Fix for the File.ContentType from MediaPicker not being in valid MIME format by @SyedAbdulAzeemSF4852 in #28842 * [Android] Fixed the Incorrect Text Color Applied to Selected Tab in TabbedPage by @Ahamed-Ali in #28844 * [iOS] Fix FlyoutPage does not respond to changes in the FlyoutLayoutBehavior property by @devanathan-vaithiyanathan in #28884 * [Android] Fixed ScalingCanvas.SetBlur not working by @NirmalKumarYuvaraj in #28911 * [iOS] - Resolved Proper Rendering of Dynamic Header/Footer Updates in CV2 by @prakashKannanSf3972 in #28641 * [iOS] Fixed the TargetInvocationException Occurs When Selecting Header/Footer After Changing ItemsLayout in CV2 by @Ahamed-Ali in #28890 * [Windows] - Fix Visual State Issue with Picker TextColor After Navigation by @prakashKannanSf3972 in #28746 ### Dependency Updates * [Windows] Upgrade to Windows App SDK 1.7 by @MartyIX in #28499 ### Testing * [Testing] Feature Matrix UITest Cases for CollectionView EmptyView Feature by @NafeelaNazhir in #28679 * Fixed Test case failure in PR 29037 - [2025/04/21] Candidate by @HarishKumarSF4517 in #29049 **Full Changelog**: main...inflight/candidate For more information about inflight process check https://github.com/dotnet/maui/wiki/Inflight-Branch-Process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details
Root Cause
Description of Change
src/Essentials/src/FileSystem/FileSystem.ios.tvos.watchos.macos.cs: Modified the PlatformGetContentType method to use UniformTypeIdentifiers.UTType.GetType for better MIME type resolution.Validated the behaviour in the following platforms
Issues Fixed
Fixes #15562
Output
Before.mov
After.mov