Fixed Refresh Color not applying to RefreshView initially.#28638
Merged
PureWeen merged 2 commits intodotnet:inflight/currentfrom Apr 18, 2025
Merged
Fixed Refresh Color not applying to RefreshView initially.#28638PureWeen merged 2 commits intodotnet:inflight/currentfrom
PureWeen merged 2 commits intodotnet:inflight/currentfrom
Conversation
Contributor
|
Hey there @Shalini-Ashokan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
dotnet-policy-service
bot
added
community ✨
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that the RefreshColor property is applied properly for RefreshView on Windows by deferring its update until the Visualizer is available.
- Introduces a property change callback to handle the asynchronous assignment of the Visualizer property.
- Adds automated tests to validate the refresh color behavior on Windows, iOS/Mac, and Android.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Core/src/Handlers/RefreshView/RefreshViewHandler.Windows.cs | Implements a callback mechanism to update RefreshColor once Visualizer is available. |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue16973.cs | Provides a shared test validating that the refresh color is correctly applied. |
| src/Controls/tests/TestCases.HostApp/Issues/Issue16973.cs | Adds a host app UI page for automated testing of the refresh color behavior across platforms. |
| }; | ||
| label = new Label | ||
| { | ||
| AutomationId = "label", |
There was a problem hiding this comment.
Ensure that the AutomationId 'label' is unique within the application context to prevent test lookup conflicts. Consider using a more descriptive and unique identifier.
| var button = new Button | ||
| { | ||
| Text = "Change Refresh Color", | ||
| AutomationId = "button", |
There was a problem hiding this comment.
Ensure that the AutomationId 'button' is unique within the application context to avoid test lookup conflicts. Consider using a more descriptive and unique identifier.
jsuarezruiz
approved these changes
Apr 14, 2025
PureWeen
pushed a commit
that referenced
this pull request
Apr 23, 2025
* Fixed the refresh color is not applied to the refresh view * Added the test case for IOS
prakashKannanSf3972
pushed a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Apr 24, 2025
NanthiniMahalingam
pushed a commit
to NanthiniMahalingam/maui
that referenced
this pull request
Apr 24, 2025
prakashKannanSf3972
pushed a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Apr 25, 2025
prakashKannanSf3972
pushed a commit
to prakashKannanSf3972/maui
that referenced
this pull request
Apr 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Fixed the refresh color is not applied to the refresh view * Added the test case for IOS
PureWeen
pushed a commit
that referenced
this pull request
May 2, 2025
* Fixed the refresh color is not applied to the refresh view * Added the test case for IOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Details
RefreshView RefreshColor does not work initially.
Root Cause
The RefreshViewVisualizer instance is initially null, preventing the RefreshColor from being set when the control is created. Since Visualizer is assigned asynchronously by the system, any attempt to set its properties too early fails.
Description of Change
To ensure that RefreshColor is applied when Visualizer becomes available, a property change callback was registered on RefreshContainer.VisualizerProperty. This callback waits until Visualizer is assigned and then applies the correct RefreshColor. Once the color is set, the callback is unregistered to avoid redundant calls.
Validated the behavior in the following platforms
Issues Fixed
Fixes #16973
Output ScreenShot
BeforeFix.2.mp4
AfterFix.3.mp4