Conversation
Contributor
There was a problem hiding this comment.
PR Overview
The purpose of this pull request is to mark TableView as obsolete for .NET 10. This change is implemented by adding an Obsolete attribute to TableView and updating various compatibility and test files to suppress CS0618 warnings around its usage.
- Added the Obsolete attribute and message in TableView.cs.
- Inserted #pragma warning disable/restore directives in renderers, extensions, and tests to prevent CS0618 warnings.
- Updated test cases and handler registrations to reflect the deprecation of TableView.
Reviewed Changes
| File | Description |
|---|---|
| src/Controls/tests/DeviceTests/TestCases/ControlsViewTypesTestCases.cs | Added pragmas around TableView usage in test cases. |
| src/Controls/src/Core/Compatibility/Handlers/TableView/Android/TableViewRenderer.cs | Inserted pragma directives to suppress warnings in the renderer. |
| src/Controls/src/Core/Internals/CellExtensions.cs | Added pragma directives where TableView methods are called. |
| src/Controls/src/Core/Compatibility/iOS/Extensions/CellExtensions.cs | Wrapped TableView-related usage with pragma directives. |
| src/Controls/tests/DeviceTests/Memory/MemoryTests.cs | Updated test cases to disable obsolete warning for TableView. |
| src/Controls/src/Core/Hosting/AppHostBuilderExtensions.cs | Suppressed CS0618 warnings when adding TableView handlers. |
| src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ViewCellRenderer.cs | Added multiple pragma directives around TableView usage. |
| src/Controls/tests/DeviceTests/Elements/Entry/EntryTests.iOS.cs | Disabled warnings for TableView usage within test cases. |
| src/Controls/src/Core/Compatibility/Handlers/TableView/Android/TableViewModelRenderer.cs | Updated constructor and member access with pragma suppression. |
| src/Controls/src/Core/TableView/TableView.cs | Marked TableView as obsolete with an appropriate message. |
| src/Controls/src/Core/Compatibility/Handlers/TableView/iOS/TableViewRenderer.cs | Applied pragma directives in the iOS renderer for TableView. |
| src/Controls/src/Core/Compatibility/Handlers/TableView/iOS/TableViewModelRenderer.cs | Wrapped TableView references with pragma directives to suppress warnings. |
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
src/Controls/src/Core/Compatibility/Handlers/TableView/Android/TableViewRenderer.cs
Show resolved
Hide resolved
src/Controls/src/Core/Compatibility/Handlers/ListView/Android/ViewCellRenderer.cs
Show resolved
Hide resolved
Contributor
|
🚨 API change(s) detected @davidbritch FYI |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Member
|
/backport to release/10.0.1xx-preview2 |
Contributor
|
Started backporting to release/10.0.1xx-preview2: https://github.com/dotnet/maui/actions/runs/13796801133 |
github-project-automation
bot
moved this from Ready To Review
to Done
in MAUI SDK Ongoing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Mark
TableViewas obsolete for .NET 10