[net10.0] Set UseRidGraph=false on Windows#27595
Merged
jfversluis merged 2 commits intodotnet:net10.0from Feb 7, 2025
Merged
Conversation
MartyIX
requested review from
StephaneDelcroix and
jfversluis
and removed request for
a team
Contributor
|
Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
MartyIX
changed the title
UseRidGraph=falseUseRidGraph=false on Windows
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
requested changes
Feb 6, 2025
Member
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
Build error :(
D:\a_work\1\s.dotnet\sdk\10.0.100-preview.2.25103.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(108,5): error NETSDK1083: The specified RuntimeIdentifier 'win10-x64' is not recognized. See https://aka.ms/netsdk1083 for more information. [D:\a_work\1\s\src\Graphics\samples\GraphicsTester.WinUI.Desktop\GraphicsTester.WinUI.Desktop.csproj]
mattleibow
approved these changes
Feb 6, 2025
Member
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jfversluis
approved these changes
Feb 7, 2025
MartyIX
commented
Feb 7, 2025
| <PublishProtocol>FileSystem</PublishProtocol> | ||
| <Platform>x64</Platform> | ||
| <RuntimeIdentifier>win10-x64</RuntimeIdentifier> | ||
| <RuntimeIdentifier>win-x64</RuntimeIdentifier> |
Contributor
Author
There was a problem hiding this comment.
@jfversluis I just noticed that this file contains win10. I should have renamed it as well, right?
jfversluis
added a commit
that referenced
this pull request
Feb 10, 2025
This reverts commit 5216687.
rmarinho
pushed a commit
that referenced
this pull request
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
I don't have .NET 10 to compile it. This is just an idea for .NET 10 (cc @mattleibow)
Issues Fixed
Fixes #17142