Skip to content

Adds very basic CSS support for Border#27529

Merged
jfversluis merged 1 commit into
dotnet:mainfrom
sthewissen:sthewissen/border-css
Feb 11, 2025
Merged

Adds very basic CSS support for Border#27529
jfversluis merged 1 commit into
dotnet:mainfrom
sthewissen:sthewissen/border-css

Conversation

@sthewissen

@sthewissen sthewissen commented Feb 3, 2025

Copy link
Copy Markdown

Description of Change

Added basic support for CSS properties that work on the Border control. The following properties are now supported:

.myNicePurpleBorder
{
   border-color: #512BD4; /* Also supports linear-gradient, radial-gradient, named colors etc. */
   border-radius: 10; /* Always maps to RoundRectangle [Radius] internally */
   border-width: 4;
}

Issues Fixed

Partially fixes #27296 to get basic support going, making it become on par with existing support for Frame, Button and ImageButton. It could definitely be expanded upon in the future for Border explicitly, but a discussion is to be had on how that would translate to missing features on the other controls that support borders.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Hey there @sthewissen! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service Bot added the community ✨ Community Contribution label Feb 3, 2025
@sthewissen sthewissen marked this pull request as ready for review February 3, 2025 08:57
@sthewissen sthewissen requested a review from a team as a code owner February 3, 2025 08:57
Comment thread src/Controls/tests/Core.UnitTests/StrokeShapeTests.cs
@rmarinho

rmarinho commented Feb 3, 2025

Copy link
Copy Markdown
Member

/rebase

@dotnet dotnet deleted a comment from jsuarezruiz Feb 3, 2025
@dotnet dotnet deleted a comment from azure-pipelines Bot Feb 3, 2025
@jsuarezruiz

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis merged commit c982f38 into dotnet:main Feb 11, 2025
@bricefriha

Copy link
Copy Markdown

Much needed, thanks @sthewissen!

@sthewissen sthewissen deleted the sthewissen/border-css branch February 12, 2025 13:52
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-border Border community ✨ Community Contribution

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add CSS support for the Border control

7 participants