Skip to content

Conversation

@pictos
Copy link
Contributor

@pictos pictos commented Jan 29, 2025

Description of Change

Issues Fixed

Fixes #17266

@pictos pictos requested a review from a team as a code owner January 29, 2025 02:51
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 29, 2025
@dotnet-policy-service
Copy link
Contributor

Hey there @pictos! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@jsuarezruiz jsuarezruiz added area-controls-dialogalert DisplayAlert, dialog area-keyboard Keyboard, soft keyboard labels Jan 29, 2025
@rmarinho rmarinho requested review from PureWeen and tj-devel709 and removed request for StephaneDelcroix and rmarinho January 30, 2025 11:21
@rmarinho
Copy link
Member

Does this align with what the other native apps do on Android?

@pictos
Copy link
Contributor Author

pictos commented Jan 30, 2025

@rmarinho good question, sadly I can't answer that I don't use android for a long time, and I can't think at any app that I can test it. Maybe @Redth would know

@jfversluis jfversluis force-pushed the pj/enter-to-dismiss-prompt branch from f53c9ee to 6a582cd Compare August 12, 2025 15:33
Copilot AI review requested due to automatic review settings August 12, 2025 15:33
@jfversluis jfversluis force-pushed the pj/enter-to-dismiss-prompt branch from 6a582cd to b03cf71 Compare August 12, 2025 15:34
@jfversluis jfversluis changed the base branch from main to inflight/current August 12, 2025 15:35
@jfversluis jfversluis force-pushed the pj/enter-to-dismiss-prompt branch from b03cf71 to b22d51f Compare August 12, 2025 15:36
@jfversluis jfversluis added this to the .NET 9 SR11 milestone Aug 12, 2025
@jfversluis jfversluis merged commit 2731cf8 into dotnet:inflight/current Aug 12, 2025
1 check passed
@pictos pictos deleted the pj/enter-to-dismiss-prompt branch August 12, 2025 15:40
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
* add support to dismiss the prompt with enter on keyboard

* Windows only

---------

Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
github-actions bot pushed a commit that referenced this pull request Aug 15, 2025
* add support to dismiss the prompt with enter on keyboard

* Windows only

---------

Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
github-actions bot pushed a commit that referenced this pull request Aug 19, 2025
* add support to dismiss the prompt with enter on keyboard

* Windows only

---------

Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
github-actions bot pushed a commit that referenced this pull request Aug 22, 2025
* add support to dismiss the prompt with enter on keyboard

* Windows only

---------

Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-dialogalert DisplayAlert, dialog area-keyboard Keyboard, soft keyboard community ✨ Community Contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shell.Current.DisplayPromptAsync doesn't react on Enter press on WinUI

4 participants