[Windows] Fixed the text and icon color issues in the DatePicker when hovering over it. by Ahamed-Ali · Pull Request #27147 · dotnet/maui

Ahamed-Ali · 2025-01-15T12:51:14Z

Issue

When the background color of the DatePicker is set to black and the text and icon colors are white, the text and icon become invisible when hovering over the DatePicker.

Root Cause of the issue

When the mouse hovers over the DatePicker, the default PointerOver color set from WinUI causes the text and icon colors to blend into the black background, making them invisible.

Description of Change

I resolved the issue by assigning the appropriate resource keys to ensure the correct colors are applied to both the DatePicker text and icon.

Issues Fixed

Fixes #22987

Test Case

Since this issue is related to hovering, a test case cannot be written.

Tested the behaviour in the following platforms

Android
Windows
iOS
Mac

Screenshot

Before Issue Fix	After Issue Fix
HoveringIssue.mp4	HoveringFixed.mp4

dotnet-policy-service · 2025-01-15T12:51:35Z

Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

jsuarezruiz · 2025-01-16T06:56:42Z

/azp run

azure-pipelines · 2025-01-16T06:57:02Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

Could you include an UITest? I can include something like a MovePointer and MovePointerToCoordinate methods.

Ahamed-Ali · 2025-01-17T10:06:12Z

Could you include an UITest? I can include something like a MovePointer and MovePointerToCoordinate methods.

I have included the test sample and test case. Could you please review them and let me know if you have any concerns? @jsuarezruiz

jsuarezruiz · 2025-01-17T11:58:30Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22987.cs

+	{
+		App.WaitForElement("Label");
+
+		//need to include something like a MovePointer and MovePointerToCoordinate methods for hovering.


Have done tests with different approaches:

Using the Hover command https://github.com/appium/appium-windows-driver?tab=readme-ov-file#windows-hover is not available in the used version:

An exception of type 'System.NotImplementedException' occurred in WebDriver.dll but was not handled in user code Unknown windows command 'hover'. Only startRecordingScreen,stopRecordingScreen,deleteFile,deleteFolder commands are supported.

Trying to move the cursor fails because using PointerKind.Mouse:
OpenQA.Selenium.WebDriverException: 'Currently only pen and touch pointer input source types are supported'

Can give a way to move the cursor using Win32, but want to test more options.

So, for now, can avoid the test, or use a Device Test to verify the color in the added resources.

Thank you for your response. I have looked into the device test for the DatePicker hovering test case but couldn't find any relevant references for it. Could you please share any related references for hovering testcase if available, or can we avoid this test for now? @jsuarezruiz

I think @mattleibow has a PR here that provides this behavior

#27477

jsuarezruiz · 2025-01-20T07:26:39Z

/azp run

azure-pipelines · 2025-01-20T07:27:00Z

Azure Pipelines successfully started running 3 pipeline(s).

Foda · 2025-01-29T21:00:28Z

Looks like a legit test fail

jsuarezruiz · 2025-02-25T10:01:08Z

/rebase

jsuarezruiz · 2025-03-03T10:41:33Z

/azp run

azure-pipelines · 2025-03-03T10:41:53Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-04T12:50:58Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22987.cs

+		App.WaitForElement("Label");
+
+		//need to include something like a MovePointer and MovePointerToCoordinate methods for hovering.
+


Pending snapshot on Windows:

Could you commit it?

The image is incorrect. I have restricted the test for now. Once implementation PR #27477 is merged, we can add MoveCursor and enable the test. @jsuarezruiz

jsuarezruiz · 2025-03-07T11:54:11Z

/rebase

jsuarezruiz · 2025-03-19T07:59:46Z

/rebase

…windows.

jsuarezruiz · 2025-03-20T09:41:35Z

/azp run

azure-pipelines · 2025-03-20T09:41:56Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz · 2025-03-21T07:07:54Z

Added Windows Device Test to validate the changes.

jsuarezruiz · 2025-03-21T07:08:57Z

Retarget to the inflight branch.

… hovering over it. (#27147) * Fixed the Hovering issue of text and icon color in the DatePicker in windows. * Included the UI test sample and test case * Modified the test * Added Device Test --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>

dotnet-policy-service bot added the community ✨ Community Contribution label Jan 15, 2025

Ahamed-Ali changed the title ~~Fixed the text and icon color issues in the DatePicker when hovering over it.~~ [Windows] Fixed the text and icon color issues in the DatePicker when hovering over it. Jan 15, 2025

karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 15, 2025

Ahamed-Ali marked this pull request as ready for review January 15, 2025 13:37

Ahamed-Ali requested a review from a team as a code owner January 15, 2025 13:37

Ahamed-Ali requested review from jfversluis and jsuarezruiz January 15, 2025 13:37

jsuarezruiz reviewed Jan 16, 2025

View reviewed changes

jsuarezruiz reviewed Jan 17, 2025

View reviewed changes

PureWeen assigned Foda Jan 27, 2025

PureWeen added this to the .NET 9 SR5 milestone Jan 27, 2025

Foda previously approved these changes Jan 27, 2025

View reviewed changes

github-actions bot force-pushed the fix-22987 branch from 1d51732 to b0a6504 Compare February 25, 2025 10:01

jsuarezruiz suggested changes Mar 4, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Changes Requested in MAUI SDK Ongoing Mar 4, 2025

Ahamed-Ali dismissed Foda’s stale review via f7a5f2a March 7, 2025 09:36

github-actions bot force-pushed the fix-22987 branch from f7a5f2a to 99cc3cd Compare March 7, 2025 11:54

PureWeen modified the milestones: .NET 9 SR5, .NET 9 SR6 Mar 7, 2025

PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Mar 18, 2025

Ahamed-Ali and others added 3 commits March 19, 2025 08:00

Fixed the Hovering issue of text and icon color in the DatePicker in …

c0e9010

…windows.

Included the UI test sample and test case

c7b3465

Modified the test

a3bfcd4

github-actions bot force-pushed the fix-22987 branch from 99cc3cd to a3bfcd4 Compare March 19, 2025 08:00

Added Device Test

0fbe978

jsuarezruiz changed the base branch from main to inflight/current March 21, 2025 07:08

jsuarezruiz approved these changes Mar 21, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Mar 21, 2025

rmarinho approved these changes Mar 21, 2025

View reviewed changes

rmarinho merged commit 67db5d5 into dotnet:inflight/current Mar 21, 2025
1 check passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Mar 21, 2025

github-actions bot locked and limited conversation to collaborators Apr 21, 2025

		App.WaitForElement("Label");

		//need to include something like a MovePointer and MovePointerToCoordinate methods for hovering.

Comments

Conversation

Ahamed-Ali commented Jan 15, 2025

Issue

Root Cause of the issue

Description of Change

Issues Fixed

Test Case

Tested the behaviour in the following platforms

Screenshot

Uh oh!

dotnet-policy-service bot commented Jan 15, 2025

Uh oh!

jsuarezruiz commented Jan 16, 2025

Uh oh!

azure-pipelines bot commented Jan 16, 2025

Uh oh!

jsuarezruiz left a comment

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali commented Jan 17, 2025

Uh oh!

jsuarezruiz Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

PureWeen Feb 3, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Jan 20, 2025

Uh oh!

azure-pipelines bot commented Jan 20, 2025

Uh oh!

Foda commented Jan 29, 2025

Uh oh!

jsuarezruiz commented Feb 25, 2025

Uh oh!

jsuarezruiz commented Mar 3, 2025

Uh oh!

azure-pipelines bot commented Mar 3, 2025

Uh oh!

jsuarezruiz Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

Ahamed-Ali Mar 7, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

jsuarezruiz commented Mar 7, 2025

Uh oh!

jsuarezruiz commented Mar 19, 2025

Uh oh!

jsuarezruiz commented Mar 20, 2025

Uh oh!

azure-pipelines bot commented Mar 20, 2025

Uh oh!

jsuarezruiz commented Mar 21, 2025

Uh oh!

jsuarezruiz commented Mar 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants