Merge fixes from XF 5.0.0 SR4 into MAUI #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…14290) * Fix width measure on TitleView * - fix test * Update ShellPageRendererTracker.cs * Update ShellTitleView.cs # Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ShellTitleView.cs # Xamarin.Forms.Platform.iOS/Renderers/ShellPageRendererTracker.cs
…4080) * Route Navigation.(Push/Pop)Modal through Shell Navigation Mananger * - fix SO error * Update ShellNavigationManager.cs # Conflicts: # Xamarin.Forms.Core.UnitTests/ShellModalTests.cs # Xamarin.Forms.Core.UnitTests/ShellNavigatingTests.cs # Xamarin.Forms.Core/Routing.cs # Xamarin.Forms.Core/Shell/RouteRequestBuilder.cs # Xamarin.Forms.Core/Shell/ShellNavigationManager.cs # Xamarin.Forms.Core/Shell/ShellSection.cs # Xamarin.Forms.Core/Shell/ShellUriHandler.cs
rachelkang
approved these changes
Jul 28, 2021
src/Controls/src/Core/Platform/Android/Shell/ShellSectionView.cs
Outdated
Show resolved
Hide resolved
samhouts
added
area-navigation
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xamarin/Xamarin.Forms#14080
xamarin/Xamarin.Forms#14290
xamarin/Xamarin.Forms#14383
xamarin/Xamarin.Forms#14101
xamarin/Xamarin.Forms#14089