[Android] Crash removing item from CarouselView

[jsuarezruiz]

Description

Crash removing item from CarouselView.

NOTE: Using 8.0.5 RC1.

Steps to Reproduce

1. Download or sync https://github.com/rachelkang/recipeSearch
2. Launch the App on Android.
3. Add a new recipe to your list.
4. Navigate back to your recipe list.
5. Select the added recipe and then tap the remove button.

Link to public reproduction project repository

https://github.com/rachelkang/recipeSearch

Version with bug

8.0.3

Is this a regression from previous behavior?

Not sure, did not test other versions

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Android 13

Did you find any workaround?

No response

Relevant log output

0xFFFFFFFFFFFFFFFF in Android.Runtime.RuntimeNativeMethods.monodroid_debugger_unhandled_exception	C#
 	0x1A in Android.Runtime.JNINativeWrapper._unhandled_exception at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:13,5	C#
 	0x1D in Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:27,26	C#
 	0x8 in System.ThrowHelper.ThrowArgumentOutOfRange_IndexMustBeLessException	C#
 	0x9 in System.Collections.Generic.List<object>.get_Item	C#
 	0x2 in System.Collections.Generic.List<object>.System.Collections.IList.get_Item	C#
 	0x11 in Microsoft.Maui.Controls.Handlers.Items.ObservableItemsSource.ElementAt at D:\a\_work\1\s\src\Controls\src\Core\Handlers\Items\Android\ItemsSources\ObservableItemsSource.cs:228,5	C#
 	0x8 in Microsoft.Maui.Controls.Handlers.Items.ObservableItemsSource.GetItem at D:\a\_work\1\s\src\Controls\src\Core\Handlers\Items\Android\ItemsSources\ObservableItemsSource.cs:67,4	C#
 	0x4F in Microsoft.Maui.Controls.Handlers.Items.MauiCarouselRecyclerView.SetCurrentItem at D:\a\_work\1\s\src\Controls\src\Core\Handlers\Items\Android\MauiCarouselRecyclerView.cs:456,4	C#
 	0xC in Microsoft.Maui.Controls.Handlers.Items.MauiCarouselRecyclerView. at D:\a\_work\1\s\src\Controls\src\Core\Handlers\Items\Android\MauiCarouselRecyclerView.cs:264,7	C#
 	0x6 in Microsoft.Maui.Dispatching.Dispatcher. at D:\a\_work\1\s\src\Core\src\Dispatching\Dispatcher.Android.cs:24,24	C#
 	0xE in Java.Lang.Thread.RunnableImplementor.Run at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Java.Lang/Thread.cs:36,6	C#
 	0x8 in Java.Lang.IRunnableInvoker.n_Run at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/obj/Release/net8.0/android-34/mcw/Java.Lang.IRunnable.cs:84,4	C#
 	0x8 in Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PP_V at /Users/runner/work/1/s/xamarin-android/src/Mono.Android/Android.Runtime/JNINativeWrapper.g.cs:26,5	C#

[jsuarezruiz]

Can reproduce it also with 8.0.3.

[npostma]

Experiencing a déjà vu. Could this possibly be a form of regression? I'm uncertain about the extent to which the old Xamarin code is still in use. I am specifically referring to: xamarin/Xamarin.Forms#14952

[edit] As I revisit that issue, I realize there was never an actual fix; only a workaround was implemented. Therefore, it's not a regression.

We've added this issue to our backlog, and we will work to address it as time and resources allow. If you have any additional information or questions about this issue, please leave a comment. For additional info about issue management, please read our Triage Process.

[RobTF]

+1 to this. Yet again blocked on bugs with CarouselView.

[dylix]

Just here so I can keep track of this.. Using the workaround at the moment...

[plppp2001]

I'm getting this error every time when I'm Removing at item from my CarouselView Collection, this happens everytime on the Last item in the CarouselView. Not sure why:

public ObservableRangeCollection<ReportCollection> UserReports { get; set; } = new();

crashes when removing the last item like so:

UserReports.Remove(reportToDelete); (on the last item in the collection for me only)

My setup:
VS2022: Version 17.9.5

Error:
System.ArgumentOutOfRangeException
Message=Index was out of range. Must be non-negative and less than the size of the collection. (Parameter 'index')

[dylix]

Just here so I can keep track of this.. Using the workaround at the moment...

What's the work around? link please?

xamarin/Xamarin.Forms#14952 (comment)

i ended up just clearing my obvcollection before adding to it, and got rid of the errors for me

[plppp2001]

Just here so I can keep track of this.. Using the workaround at the moment...

What's the work around? link please?

xamarin/Xamarin.Forms#14952 (comment)

i ended up just clearing my obvcollection before adding to it, and got rid of the errors for me

What about Removing an item from the collection for CarouselVIew?

public ObservableRangeCollection UserReports { get; set; } = new();

Your doing this, by what you mean Clearing?

UserReports.Clear(); ?

The target is a property that is implemented using a special property called a BindableProperty. The object with the BindableProperty must derive from BindableObject. All of the controls provided in .NET MAUI derive from BindableObject and most of their properties are BindableProperties.

[plppp2001]

I did this for now to be able to delete items from CarouselView on ANdroid using the "ObservableRangeCollection":

public ObservableRangeCollection<HistoryCollection> UserReports { get; set; } = new();  //this is for my CarsoueView Source on xaml page - shows 20 reports at one time I have a Load More reports button for the users for the carasouelview
private List<UserHistoryCollection> UserHistories = new();  //this hold like about 100 reports in memory filled up on PageLoad from HttpGet

//https://github.com/jamesmontemagno/mvvm-helpers
//Using MVVM CommunityToolkit.Mvvm  this is in the VM  just the code snippet for delete-------------------

   private async Task DeleteForAndroidWorkAroundBugAsync(UserHistoryCollection ReportToDelete)
    {
        UserHistories.Remove(ReportToDelete);

        int currentItemCount = UserReports.Count;

        if (UserReports.Any())
            UserReports.Clear();

        await Task.Delay(TimeSpan.FromSeconds(1)); //you need this here, stupid but it works for me anyways

        if (currentItemCount > 0)
        {
            if (UserHistories.Any())
            {
                UserReports.AddRange(UserHistories.Take(currentItemCount));
            }
            else
            {
                UserReports.Clear();
            }
                
        }
    }

[RobTF]

Ah, the old await Task.Delay(..) hack... a staple of a good MAUI "fix" ;)

@plppp2001 Your fix is astute and I've seen similar in other codebases, but if you're flushing the collection each time you can probably just get rid of ObservableCollection and just swap out the enumeration entirely as you're not getting any benefit from the observable functionality.

var newReports = UserReports.Except(x => x === toDelete);
UserReports = newReports;