Skip to content

Commit d287475

Browse files
[XSG] enable diagnostis by default on Debug (#32052)
if EnableDiagnostics isn't set, defaut to true on Debug builds - fixes #32047
1 parent dc8b538 commit d287475

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/Controls/src/Build.Tasks/nuget/buildTransitive/netstandard2.0/Microsoft.Maui.Controls.Common.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,5 +29,6 @@
2929
<CompilerVisibleItemMetadata Include="AdditionalFiles" MetadataName="EnableDiagnostics" />
3030
<CompilerVisibleProperty Include="MauiXamlLineInfo" />
3131
<CompilerVisibleItemMetadata Include="AdditionalFiles" MetadataName="LineInfo" />
32+
<CompilerVisibleProperty Include="Configuration" />
3233
</ItemGroup>
3334
</Project>

src/Controls/src/SourceGen/ProjectItem.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,11 @@ public bool EnableDiagnostics
3232
return true;
3333
if (Options.IsFalse("build_metadata.additionalfiles.EnableDiagnostics"))
3434
return false;
35-
return Options.IsTrue("build_property.EnableMauiXamlDiagnostics");
35+
if (Options.IsTrue("build_property.EnableMauiXamlDiagnostics"))
36+
return true;
37+
if (Options.IsFalse("build_property.EnableMauiXamlDiagnostics"))
38+
return false;
39+
return !Configuration.Equals("Release", StringComparison.OrdinalIgnoreCase);
3640
}
3741
}
3842

0 commit comments

Comments
 (0)