Fixed the RealParent Warning shown issue (#30156)

* Safe Get of RealParent to avoid warnings

* Optimized the fix

* Make it as default private

* Optimized the fix

* Modified the fix and added test

* Modified the fix based on concern and added test

* unwanted spacing

* Replaced the Parent property directly

Author: Ahamed-Ali

src/Controls/src/Core/Element/Element.cs

@@ -333,30 +333,39 @@ internal Element ParentOverride
 		}
 
 		WeakReference<Element> _realParent;
-		/// <summary>For internal use by .NET MAUI.</summary>
-		[EditorBrowsable(EditorBrowsableState.Never)]
-		public Element RealParent
+		Element TryGetRealParent(bool logWarningIfParentHasBeenCollected = true)
 		{
-			get
+			var realParent = _realParent;
+			if (realParent is null)
 			{
-				if (_realParent is null)
-				{
-					return null;
-				}
-				if (_realParent.TryGetTarget(out var parent))
-				{
-					return parent;
-				}
-				else
+				return null;
+			}
+			if (realParent.TryGetTarget(out var parent))
+			{
+				return parent;
+			}
+			else
+			{
+				// Clear the weak reference since the target has been garbage collected
+				// This prevents repeated checks and warnings on subsequent accesses
+				_realParent = null;
+				if (logWarningIfParentHasBeenCollected)
 				{
 					Application.Current?
-						.FindMauiContext()?
-						.CreateLogger<Element>()?
-						.LogWarning($"The RealParent on {this} has been Garbage Collected. This should never happen. Please log a bug: https://github.com/dotnet/maui");
+										.FindMauiContext()?
+										.CreateLogger<Element>()?
+										.LogWarning($"The RealParent on {this} has been Garbage Collected. This should never happen. Please log a bug: https://github.com/dotnet/maui");
 				}
-
-				return null;
 			}
+
+			return null;
+		}
+
+		/// <summary>For internal use by .NET MAUI.</summary>
+		[EditorBrowsable(EditorBrowsableState.Never)]
+		public Element RealParent
+		{
+			get => TryGetRealParent();
 			private set
 			{
 				if (value is null)
@@ -386,7 +395,7 @@ public Element Parent
 
 		void SetParent(Element value)
 		{
-			Element realParent = RealParent;
+			Element realParent = TryGetRealParent(false);
 
 			if (realParent == value)
 			{

src/Controls/tests/Core.UnitTests/ElementTests.cs

@@ -313,5 +313,126 @@ public void ChildRemoved()
 			root.Children.Remove(child);
 			Assert.True(removed);
 		}
+
+		[Fact]
+		public void RealParent_ReturnsNullAfterParentGarbageCollected()
+		{
+			var child = new TestElement();
+			WeakReference parentRef;
+
+			// Create parent in separate scope to enable GC
+			void CreateParent()
+			{
+				var parent = new TestElement();
+				parentRef = new WeakReference(parent);
+				parent.Children.Add(child);
+				// parent goes out of scope here
+			}
+
+			CreateParent();
+
+			// Force garbage collection
+			GC.Collect();
+			GC.WaitForPendingFinalizers();
+			GC.Collect();
+
+			// Verify parent was collected
+			Assert.False(parentRef.IsAlive);
+
+			// RealParent should return null and not throw
+			Assert.Null(child.RealParent);
+		}
+
+		[Fact]
+		public void SetParent_DoesNotLogWarningWhenParentGarbageCollected()
+		{
+			var child = new TestElement();
+			WeakReference parentRef;
+
+			// Create parent in separate scope
+			void CreateParent()
+			{
+				var parent = new TestElement();
+				parentRef = new WeakReference(parent);
+				parent.Children.Add(child);
+			}
+
+			CreateParent();
+
+			// Force garbage collection
+			GC.Collect();
+			GC.WaitForPendingFinalizers();
+			GC.Collect();
+
+			// Setting parent should not log warnings internally
+			var newParent = new TestElement();
+			newParent.Children.Add(child);
+
+			Assert.Same(newParent, child.RealParent);
+		}
+
+		[Fact]
+		public void RealParent_ReturnsNull_WhenNoParentSet()
+		{
+			var element = new TestElement();
+			Assert.Null(element.RealParent);
+		}
+
+		[Fact]
+		public void RealParent_IsThreadSafe_WhenAccessedConcurrently()
+		{
+			var element = new TestElement();
+			var parent = new TestElement();
+			parent.Children.Add(element);
+
+			// Act - Create multiple threads accessing and modifying RealParent concurrently
+			const int ThreadCount = 10;
+			var threads = new System.Threading.Thread[ThreadCount];
+			var exceptions = new List<Exception>();
+			var threadBarrier = new System.Threading.Barrier(ThreadCount);
+
+			for (int i = 0; i < ThreadCount; i++)
+			{
+				threads[i] = new System.Threading.Thread(() =>
+				{
+					try
+					{
+						// Synchronize threads to increase chance of concurrent access
+						threadBarrier.SignalAndWait();
+
+						// Some threads read the parent
+						element.RealParent?.ToString();
+
+						// Clear reference to parent so GC can collect it
+						parent = null;
+
+						// Force garbage collection on some threads
+						GC.Collect();
+						GC.WaitForPendingFinalizers();
+						GC.Collect();
+
+						// Try to access the parent again after potential collection
+						element.RealParent?.ToString();
+					}
+					catch (Exception ex)
+					{
+						lock (exceptions)
+						{
+							exceptions.Add(ex);
+						}
+					}
+				});
+				threads[i].Start();
+			}
+
+			// Wait for all threads to complete
+			foreach (var thread in threads)
+			{
+				thread.Join();
+			}
+
+			// Assert - No exceptions should be thrown during concurrent access
+			Assert.Empty(exceptions);
+		}
 	}
 }