Remove usage of MasterDetailPage

Author: rmarinho

src/Compatibility/ControlGallery/src/Core/ControlGalleryPages/AppearingGalleryPage.cs

@@ -9,7 +9,7 @@ namespace Microsoft.Maui.Controls.Compatibility.ControlGallery
 	public class AppearingGalleryPage : ContentPage
 	{
 		const string NavPageTitle = "NavAppearingPage";
-		const string MasterPageTitle = "MasterAppearingPage";
+		const string FlyoutPageTitle = "FlyoutPageAppearingPage";
 		const string TabbedPageTitle = "TabbedAppearingPage";
 		const string CarouselPageTitle = "CarouselAppearingPage";
 
@@ -27,9 +27,9 @@ public AppearingGalleryPage()
 						Application.Current.MainPage = new NavAppearingPage(initalPage);
 						})
 					},
-					new Button { Text = MasterPageTitle, Command = new Command (() => {
+					new Button { Text = FlyoutPageTitle, Command = new Command (() => {
 						var page = new FlyoutPage {
-							Title = MasterPageTitle,
+							Title = FlyoutPageTitle,
 							Flyout = new ContentPage { Title = "Flyout", BackgroundColor = Colors.Red },
 							Detail =  new NavAppearingPage(initalPage)
 						};

src/Compatibility/ControlGallery/src/Core/GalleryPages/BackgroundImageGallery.cs

@@ -86,7 +86,7 @@ await Navigation.PushAsync(new TabbedPage
 				});
 			};
 
-			var master = new Button { Text = "MasterDetail" };
+			var master = new Button { Text = "FlyoutPage" };
 			master.Clicked += async (sender, args) =>
 			{
 				await Navigation.PushModalAsync(new FlyoutPage

src/Compatibility/ControlGallery/src/Core/GalleryPages/FlyoutPageTabletPage.cs

@@ -7,7 +7,7 @@ public class FlyoutPageTabletPage : ContentPage
 	{
 		public FlyoutPageTabletPage()
 		{
-			Title = "MasterDetail FlyoutLayoutBehavior Gallery";
+			Title = "FlyoutPage FlyoutLayoutBehavior Gallery";
 
 			var btn = new Button { Text = "Default (old behavior)" };
 			btn.Clicked += async (sender, e) => await Navigation.PushModalAsync(new Issue1461Page(FlyoutLayoutBehavior.Default, null));

src/Compatibility/ControlGallery/src/Core/GalleryPages/TitleView.xaml

@@ -11,8 +11,8 @@
 	</NavigationPage.TitleView>
 	<ScrollView>
 		<StackLayout BackgroundColor="Pink">
-			<Button Clicked="masterDetailsPage_Clicked" Text="Flyout Details Page"></Button>
-			<Button Clicked="masterDetailsPageIcon_Clicked" Text="Toggle MDP Icon"></Button>
+			<Button Clicked="flyoutPagesPage_Clicked" Text="Flyout Details Page"></Button>
+			<Button Clicked="flyoutPagesPageIcon_Clicked" Text="Toggle MDP Icon"></Button>
 			<Button Clicked="tabbedPage_Clicked" Text="Tabbed Page"></Button>
 			<Button Clicked="navigationPage_Clicked" Text="Navigation Page"></Button>
 			<Button Clicked="nextPage_Clicked" Text="Push a Page"></Button>

src/Compatibility/ControlGallery/src/Core/GalleryPages/TitleView.xaml.cs

@@ -21,7 +21,7 @@ public TitleView(bool initialLoad)
 
 			if (initialLoad)
 			{
-				Device.BeginInvokeOnMainThread(() => masterDetailsPage_Clicked(this, EventArgs.Empty));
+				Device.BeginInvokeOnMainThread(() => flyoutPagesPage_Clicked(this, EventArgs.Empty));
 			}
 		}
 
@@ -48,7 +48,7 @@ void swapDetails_Page(object sender, EventArgs e)
 			}
 		}
 
-		void masterDetailsPage_Clicked(object sender, EventArgs e)
+		void flyoutPagesPage_Clicked(object sender, EventArgs e)
 		{
 			App.Current.MainPage =
 				new FlyoutPage()
@@ -195,7 +195,7 @@ static void toggleTitleIcon(Page page)
 				NavigationPage.SetTitleIconImageSource(page, null);
 		}
 
-		void masterDetailsPageIcon_Clicked(object sender, EventArgs e)
+		void flyoutPagesPageIcon_Clicked(object sender, EventArgs e)
 		{
 			if (App.Current.MainPage is FlyoutPage mdp)
 			{

src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla30835.cs

@@ -15,7 +15,7 @@ namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues
 	[Category(Compatibility.UITests.UITestCategories.Bugzilla)]
 #endif
 	[Preserve(AllMembers = true)]
-	[Issue(IssueTracker.Bugzilla, 30835, "Navigating to and from the Carousel page with MasterDetail page creates an Out of memory exception")]
+	[Issue(IssueTracker.Bugzilla, 30835, "Navigating to and from the Carousel page with FlyoutPage creates an Out of memory exception")]
 	public class Bugzilla30835 : TestFlyoutPage // or TestFlyoutPage, etc ...
 	{
 		protected override void Init()

src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla32776.cs

@@ -8,7 +8,7 @@ namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues
 #if UITEST
 	[NUnit.Framework.Category(Compatibility.UITests.UITestCategories.Bugzilla)]
 #endif
-	[Issue(IssueTracker.Bugzilla, 32776, "MasterDetail page - page title not showing for Windows Phone 8.1 (any orientation) or in Windows 8.1 (portrait orientation).", PlatformAffected.WinRT, NavigationBehavior.PushModalAsync)]
+	[Issue(IssueTracker.Bugzilla, 32776, "FlyoutPage - page title not showing for Windows Phone 8.1 (any orientation) or in Windows 8.1 (portrait orientation).", PlatformAffected.WinRT, NavigationBehavior.PushModalAsync)]
 	public class Bugzilla32776
 		: FlyoutPage
 	{

src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla32902.cs

@@ -88,7 +88,7 @@ protected override void Init()
 				}
 			});
 
-			//MASTERDETAIL PAGE
+			//FLYOUTPAGE PAGE
 			HomePage = new FlyoutPage()
 			{
 				Flyout = MasterPage,

src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla43519.cs

@@ -11,7 +11,7 @@
 namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues
 {
 	[Preserve(AllMembers = true)]
-	[Issue(IssueTracker.Bugzilla, 43519, "[UWP] MasterDetail page ArguementException when nested in a TabbedPage and returning from modal page"
+	[Issue(IssueTracker.Bugzilla, 43519, "[UWP] FlyoutPage ArgumentException when nested in a TabbedPage and returning from modal page"
 		, PlatformAffected.UWP)]
 
 #if UITEST

src/Compatibility/ControlGallery/src/Issues.Shared/Bugzilla46494.cs

@@ -13,7 +13,7 @@ namespace Microsoft.Maui.Controls.Compatibility.ControlGallery.Issues
 	[NUnit.Framework.Category(Compatibility.UITests.UITestCategories.Bugzilla)]
 #endif
 	[Preserve(AllMembers = true)]
-	[Issue(IssueTracker.Bugzilla, 46494, "Hardware/Software back button from MainPage of type MasterDetail causes crash 'java.lang.IllegalStateException: Activity has been destroyed'", PlatformAffected.Android)]
+	[Issue(IssueTracker.Bugzilla, 46494, "Hardware/Software back button from MainPage of type FlyoutPage causes crash 'java.lang.IllegalStateException: Activity has been destroyed'", PlatformAffected.Android)]
 	public class Bugzilla46494 : TestFlyoutPage
 	{
 		protected override void Init()