Skip to content

Commit 51f0651

Browse files
authored
Remove extra (managed) setters on readonly (native) properties (#11907)
When used they can cause rejection from the app store (but in most case the managed linker will remove them from the app code)
1 parent 51ba9f3 commit 51f0651

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed

src/mlcompute.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -567,7 +567,13 @@ interface MLCTensor : NSCopying {
567567
MLCDevice Device { get; }
568568

569569
[Export ("optimizerData", ArgumentSemantic.Copy)]
570-
MLCTensorData[] OptimizerData { get; set; }
570+
MLCTensorData[] OptimizerData {
571+
get;
572+
#if !XAMCORE_4_0
573+
[NotImplemented]
574+
set;
575+
#endif
576+
}
571577

572578
[Export ("optimizerDeviceData", ArgumentSemantic.Copy)]
573579
MLCTensorOptimizerDeviceData[] OptimizerDeviceData { get; }

src/networkextension.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1686,7 +1686,12 @@ interface NEFilterSocketFlow {
16861686
NWEndpoint LocalEndpoint { get; }
16871687

16881688
[Export ("socketFamily")]
1689-
int SocketFamily { get; set; }
1689+
int SocketFamily {
1690+
get;
1691+
#if !XAMCORE_4_0
1692+
[NotImplemented] set;
1693+
#endif
1694+
}
16901695

16911696
[Export ("socketType")]
16921697
int SocketType {

src/vision.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1707,7 +1707,13 @@ interface VNImageAlignmentObservation {
17071707
interface VNImageTranslationAlignmentObservation {
17081708

17091709
[Export ("alignmentTransform", ArgumentSemantic.Assign)]
1710-
CGAffineTransform AlignmentTransform { get; set; }
1710+
CGAffineTransform AlignmentTransform {
1711+
get;
1712+
#if !XAMCORE_4_0
1713+
[NotImplemented]
1714+
set;
1715+
#endif
1716+
}
17111717
}
17121718

17131719
[TV (11,0), Mac (10,13), iOS (11,0)]
@@ -1719,8 +1725,10 @@ interface VNImageHomographicAlignmentObservation {
17191725
Matrix3 WarpTransform {
17201726
[MarshalDirective (NativePrefix = "xamarin_simd__", Library = "__Internal")]
17211727
get;
1722-
[MarshalDirective (NativePrefix = "xamarin_simd__", Library = "__Internal")]
1728+
#if !XAMCORE_4_0
1729+
[NotImplemented]
17231730
set;
1731+
#endif
17241732
}
17251733
}
17261734

0 commit comments

Comments
 (0)