Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 29, 2025

Users building on Windows with VS2019, VS2022, or VS2026 need updated documentation for proper build environment setup.

Changes

CMake version requirements:

  • Documented that CMake 4.0+ is now supported
  • Specified minimum versions: CMake 3.14+ for VS2019, CMake 3.21+ for VS2022, CMake 4.2+ for VS2026

Visual Studio installation section:

  • Generalized installation instructions to cover VS 2019, 2022, and 2026
  • Added introductory text explaining similarities across versions
  • Documented MSVC toolset version mapping (v142 for VS 2019, v143 for VS 2022, v145 for VS 2026)
  • Changed section headers to "(Example)" format to indicate reference examples
  • Added comprehensive VS2022 installation instructions with Spectre-mitigated libraries:
    • MSVC v143 - VS 2022 C++ x64/x86 Spectre-mitigated libs (Latest)
    • ARM/ARM64 variants for cross-compilation
  • Updated Spectre-mitigated libraries note to be version-agnostic, covering all VS versions
  • Documented location in VS Installer: Individual components → Compilers, build tools, and runtimes

Documentation structure improvements:

  • Reorganized VS installation sections with clear hierarchy showing examples for VS 2022 and VS 2019
  • Updated all build instruction references to include VS 2019, 2022, and 2026
  • Enhanced Known Issues section with CMake version compatibility information for all three VS versions

File: docs/building/windows-instructions.md

Original prompt

This section details on the original issue you should resolve

<issue_title>Build instructions: CMake < 4.0 and spectre-mitigation</issue_title>
<issue_description>System Information (please complete the following information):

  • OS & Version: Windows 11, VS2022
  • ML.NET Version: main from github 17th May 2025

Describe the bug
To compile the project on Windows:
CMake 4.0.2 return error "path not found"
Spectre-mitigated libraries are needed in VS2022

To Reproduce
Steps to reproduce the behavior:

  1. Clean machine
  2. Install VS2022 and follow instructions on developer page
  3. Install latest CMake
  4. Observe errors trying to build Native libraries

Additional context
Minor update needed https://github.com/dotnet/machinelearning/blob/main/docs/building/windows-instructions.md on Individual Components needed and probably a notice on using CMake <4.0.0
</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits October 29, 2025 21:30
… and Spectre-mitigated libs requirement

Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CMake build instructions for Windows with spectre mitigation Update Windows build instructions for CMake 4.0 incompatibility and Spectre-mitigated libraries Oct 29, 2025
Copilot AI requested a review from ericstj October 29, 2025 21:35
Copilot finished work on behalf of ericstj October 29, 2025 21:35
@ericstj
Copy link
Member

ericstj commented Oct 29, 2025

Actually CMake 4.0 should work just fine. I needed this for 694bc60.

VS 2026 also works now.

@copilot can you please update the docs accordingly?

Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 29, 2025

Actually CMake 4.0 should work just fine. I needed this for 694bc60.

VS 2026 also works now.
...

Updated the documentation to reflect CMake 4.0+ support. Removed the incompatibility warnings and added a note that CMake 4.0 and later versions are now supported. Commit: 94d6cdf

Copilot AI changed the title Update Windows build instructions for CMake 4.0 incompatibility and Spectre-mitigated libraries Update Windows build instructions for CMake 4.0+ support and Spectre-mitigated libraries Oct 29, 2025
Copilot finished work on behalf of ericstj October 29, 2025 22:24
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot address feedback

Co-authored-by: ericstj <8918108+ericstj@users.noreply.github.com>
Copilot AI changed the title Update Windows build instructions for CMake 4.0+ support and Spectre-mitigated libraries Update Windows build instructions for CMake 4.0+ support, Spectre-mitigated libraries, and VS 2026 Oct 29, 2025
Copilot AI requested a review from ericstj October 29, 2025 23:21
Copilot finished work on behalf of ericstj October 29, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build instructions: CMake < 4.0 and spectre-mitigation

2 participants