Skip to content

update cmake mac #7443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged

update cmake mac #7443

merged 8 commits into from
Apr 23, 2025

Conversation

michaelgsharp
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.00%. Comparing base (500385b) to head (c3e89ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7443      +/-   ##
==========================================
- Coverage   69.00%   69.00%   -0.01%     
==========================================
  Files        1482     1482              
  Lines      273876   273876              
  Branches    28254    28254              
==========================================
- Hits       188979   188975       -4     
- Misses      77514    77516       +2     
- Partials     7383     7385       +2     
Flag Coverage Δ
Debug 69.00% <ø> (-0.01%) ⬇️
production 63.28% <ø> (-0.01%) ⬇️
test 89.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this resolves the error.

@ericstj ericstj marked this pull request as ready for review April 21, 2025 19:29
@ericstj
Copy link
Member

ericstj commented Apr 23, 2025

Change fixed the install step, but build was failing in the same way. I updated cmake_minimum_required(VERSION 3.20) since that's what I see we use in runtime for our native libs in net8.0: https://github.com/dotnet/runtime/blob/4f67954b64888688b52ad62c4bce8836f8e6e103/src/native/libs/CMakeLists.txt#L1

@michaelgsharp
Copy link
Member Author

/ba-g test failure is a known issue.

@michaelgsharp michaelgsharp merged commit d070dcb into main Apr 23, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants