[release/4.0] Support O3 OpenAI model mapping#7395
Merged
ericstj merged 2 commits intorelease/4.0from Feb 21, 2025
Merged
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/4.0 #7395 +/- ##
==============================================
Coverage ? 68.89%
==============================================
Files ? 1470
Lines ? 274081
Branches ? 28405
==============================================
Hits ? 188821
Misses ? 77944
Partials ? 7316
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericstj
approved these changes
Feb 21, 2025
Member
|
/ba-g all failures are #6978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7394 to release/4.0
/cc @tarekgh
Customer Impact
Users will be able to create a tokenizer object for the OpenAI o1 and o3 models.
Testing
Manually tested it and added a test specific to these models.
Risk
Very low. No real code change, only allow accepting the model names "o1" and "o3" to create the tokenizer instance.