Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenAI] Add readme to Microsoft.ML.GenAI.Phi #7206

Merged

Conversation

LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Jul 31, 2024

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

Copy link
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @LittleLittleCloud. Added a few suggestions.

src/Microsoft.ML.GenAI.Phi/README.md Outdated Show resolved Hide resolved
# Microsoft.ML.GenAI.Phi
Torchsharp implementation of Microsoft phi-series models for GenAI

## Supported list
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the ones that aren't checked, do we have a path to support them? If not, maybe remove them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am working on implementing those models

src/Microsoft.ML.GenAI.Phi/README.md Outdated Show resolved Hide resolved
src/Microsoft.ML.GenAI.Phi/README.md Outdated Show resolved Hide resolved
src/Microsoft.ML.GenAI.Phi/README.md Outdated Show resolved Hide resolved
src/Microsoft.ML.GenAI.Phi/README.md Outdated Show resolved Hide resolved
src/Microsoft.ML.GenAI.Phi/README.md Outdated Show resolved Hide resolved
LittleLittleCloud and others added 6 commits August 5, 2024 13:33
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
@LittleLittleCloud LittleLittleCloud merged commit 5f5a199 into dotnet:main Aug 5, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants