-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GenAI core package #7177
Add GenAI core package #7177
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7177 +/- ##
==========================================
- Coverage 68.67% 68.67% -0.01%
==========================================
Files 1263 1263
Lines 257955 257955
Branches 26698 26698
==========================================
- Hits 177148 177140 -8
- Misses 73994 74001 +7
- Partials 6813 6814 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
src/Microsoft.ML.GenAI.Core/Extension/CausalMLPipelineExtension.cs
Outdated
Show resolved
Hide resolved
string[]? stopSequences = null, | ||
int eosId = 0, | ||
string device = "cpu", | ||
bool bos = true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We prefer to have these things in a "default" class. If you look at the normal transformers you can see how we do it.
NOT a blocking issue though.
We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.#7169 Task 2