-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change official build to use 1ES templates #7048
Conversation
This reverts commit fd9fb10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Our official builds don't run tests, so we might want to do some basic tests that the content that comes out looks good. I imagine just a quick check that the packages contain the same runtime folders as before and bits are signed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7048 +/- ##
=======================================
Coverage 68.81% 68.81%
=======================================
Files 1255 1255
Lines 250248 250248
Branches 25533 25533
=======================================
+ Hits 172197 172200 +3
+ Misses 71442 71441 -1
+ Partials 6609 6607 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor suggestions. I spot checked the internal build and it seemed OK. I noticed no files missing from the Microsoft.ML package and the binaries were signed.
Also FYI @michaelgsharp |
With any luck this doesn't break our builds (official build tests have been done from a branch)
* Change official build to use 1ES templates (#7048) With any luck this doesn't break our builds (official build tests have been done from a branch) * Updated for https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build?definitionId=1110 by using baselines generated in https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build/results?buildId=2396001 (#7051) Co-authored-by: MerlinBot <merlinbotcore@microsoft.com> * testing arm python brew overwite (#7058) * testing arm python brew overwite * more m1 testing * Install python@3.12 before libomp * Update official build libomp install command --------- Co-authored-by: Eric StJohn <ericstj@microsoft.com> --------- Co-authored-by: Jo Shields <directhex@apebox.org> Co-authored-by: MerlinBot <merlinbotcore@microsoft.com> Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>
There'll be SDL issues to take care of too once autobaselining happens