Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change official build to use 1ES templates #7048

Merged
merged 27 commits into from
Mar 6, 2024
Merged

Conversation

directhex
Copy link
Contributor

There'll be SDL issues to take care of too once autobaselining happens

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Our official builds don't run tests, so we might want to do some basic tests that the content that comes out looks good. I imagine just a quick check that the packages contain the same runtime folders as before and bits are signed.

build/vsts-ci.yml Outdated Show resolved Hide resolved
build/vsts-ci.yml Show resolved Hide resolved
build/vsts-ci.yml Show resolved Hide resolved
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.81%. Comparing base (164fde0) to head (d9cfbbc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7048   +/-   ##
=======================================
  Coverage   68.81%   68.81%           
=======================================
  Files        1255     1255           
  Lines      250248   250248           
  Branches    25533    25533           
=======================================
+ Hits       172197   172200    +3     
+ Misses      71442    71441    -1     
+ Partials     6609     6607    -2     
Flag Coverage Δ
Debug 68.81% <ø> (+<0.01%) ⬆️
production 63.25% <ø> (+<0.01%) ⬆️
test 88.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor suggestions. I spot checked the internal build and it seemed OK. I noticed no files missing from the Microsoft.ML package and the binaries were signed.

@ericstj
Copy link
Member

ericstj commented Mar 5, 2024

Also FYI @michaelgsharp

@directhex directhex merged commit 8d31a8e into dotnet:main Mar 6, 2024
25 checks passed
ericstj pushed a commit to ericstj/machinelearning that referenced this pull request Mar 13, 2024
With any luck this doesn't break our builds (official build tests have been done from a branch)
ericstj added a commit that referenced this pull request Mar 14, 2024
* Change official build to use 1ES templates (#7048)

With any luck this doesn't break our builds (official build tests have been done from a branch)

* Updated for https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build?definitionId=1110 by using baselines generated in https://dev.azure.com/dnceng/7ea9116e-9fac-403d-b258-b31fcf1bb293/_build/results?buildId=2396001 (#7051)

Co-authored-by: MerlinBot <merlinbotcore@microsoft.com>

* testing arm python brew overwite (#7058)

* testing arm python brew overwite

* more m1 testing

* Install python@3.12 before libomp

* Update official build libomp install command

---------

Co-authored-by: Eric StJohn <ericstj@microsoft.com>

---------

Co-authored-by: Jo Shields <directhex@apebox.org>
Co-authored-by: MerlinBot <merlinbotcore@microsoft.com>
Co-authored-by: Michael Sharp <51342856+michaelgsharp@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants