Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak CreateByModelNameAsync #7015

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Tweak CreateByModelNameAsync #7015

merged 1 commit into from
Feb 20, 2024

Commits on Feb 20, 2024

  1. Tweak CreateByModelNameAsync 

    - Add a CancellationToken to CreateByModelNameAsync, allowing the download and parsing to be canceled.
- Use ReadLineAsync(cancellationToken), which not only allows it to be canceled, but avoids ~100K task allocations
- Fix Helpers.FromBase64String to support lines longer than 300 chars
    @stephentoub
    stephentoub committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    2eadb5b View commit details
    Browse the repository at this point in the history