Reorganize dataframe files #6872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files # Conflicts: # src/Microsoft.Data.Analysis/DataFrameColumns/ArrowStringDataFrameColumn.cs # src/Microsoft.Data.Analysis/DataFrameColumns/StringDataFrameColumn.cs # src/Microsoft.Data.Analysis/DataFrameColumns/VBufferDataFrameColumn.cs # src/Microsoft.Data.Analysis/PrimitiveColumnContainer.cs
ghost
added
the
|
@michaelgsharp could you please take a look and approve while Jake is on vacation? There isn't any changes in the code. This PR reorganizes files inside dataframe project to simplify project structure and make it easier to change unit tests (and track these changes) in future development |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6872 +/- ##
==========================================
+ Coverage 69.40% 69.46% +0.06%
==========================================
Files 1238 1249 +11
Lines 249462 250702 +1240
Branches 25522 25875 +353
==========================================
+ Hits 173139 174154 +1015
- Misses 69578 69803 +225
Partials 6745 6745
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
michaelgsharp
approved these changes
Dec 7, 2023
michaelgsharp
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code is not changed. This PR only reorganizes files (moves all PrimitiveDataFrameColumns and internal util under separate folders, split unit tests into separate files based on the area being tested). The aim of this PR is to make futher development easier.