Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed mac build and minor torch sharp changes #6776

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

michaelgsharp
Copy link
Member

Fixes the mac build issue with the official pipeline.

Also adds in specific options classes for SentenceSimilarity and TextClassification so that each can be given their own defaults.

@michaelgsharp
Copy link
Member Author

@zewditu @JakeRadMSFT @LittleLittleCloud this fixes the mac build issue for the nightly nuget builds.

It also adds in specific options classes for SentenceSimilarity and TextClassification. Are you using the options class in automl/model builder? From the code Luis shared with me it didn't seem like that was the case. If not, nothing needs to change on your end. If you are using the options class, you just have to change the class name as none of the members themselves changed.

@zewditu
Copy link
Contributor

zewditu commented Jul 26, 2023

@zewditu @JakeRadMSFT @LittleLittleCloud this fixes the mac build issue for the nightly nuget builds.

It also adds in specific options classes for SentenceSimilarity and TextClassification. Are you using the options class in automl/model builder? From the code Luis shared with me it didn't seem like that was the case. If not, nothing needs to change on your end. If you are using the options class, you just have to change the class name as none of the members themselves changed.

@michaelgsharp thanks for letting us to know this, I think in Model Builder we used Options, is that right @LittleLittleCloud ?

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #6776 (56823fc) into main (65c7ca9) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 94.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6776      +/-   ##
==========================================
- Coverage   69.00%   68.98%   -0.02%     
==========================================
  Files        1237     1237              
  Lines      252836   252848      +12     
  Branches    26445    26445              
==========================================
- Hits       174460   174430      -30     
- Misses      71446    71480      +34     
- Partials     6930     6938       +8     
Flag Coverage Δ
Debug 68.98% <94.73%> (-0.02%) ⬇️
production 63.55% <100.00%> (-0.02%) ⬇️
test 88.83% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/Microsoft.ML.TorchSharp/TorchSharpCatalog.cs 69.23% <ø> (ø)
test/Microsoft.ML.Tests/TextClassificationTests.cs 85.17% <0.00%> (+0.49%) ⬆️
...ML.TorchSharp/NasBert/SentenceSimilarityTrainer.cs 89.39% <100.00%> (+0.68%) ⬆️
...ML.TorchSharp/NasBert/TextClassificationTrainer.cs 95.65% <100.00%> (+0.14%) ⬆️

... and 6 files with indirect coverage changes

@michaelgsharp michaelgsharp merged commit 8952994 into dotnet:main Jul 28, 2023
23 checks passed
@michaelgsharp michaelgsharp deleted the mac-build branch July 28, 2023 03:46
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants