Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to filter dataframe column by null via ElementWise Methods #6723

Merged
merged 5 commits into from
Jul 7, 2023
Merged

Provide ability to filter dataframe column by null via ElementWise Methods #6723

merged 5 commits into from
Jul 7, 2023

Conversation

asmirnov82
Copy link
Contributor

Fixes #6110

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #6723 (4c772c8) into main (caee3c2) will increase coverage by 0.01%.
The diff coverage is 95.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6723      +/-   ##
==========================================
+ Coverage   68.88%   68.89%   +0.01%     
==========================================
  Files        1216     1216              
  Lines      251137   251221      +84     
  Branches    26269    26275       +6     
==========================================
+ Hits       172997   173083      +86     
  Misses      71313    71313              
+ Partials     6827     6825       -2     
Flag Coverage Δ
Debug 68.89% <95.23%> (+0.01%) ⬆️
production 63.39% <90.47%> (+<0.01%) ⬆️
test 88.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
....Data.Analysis/DataFrameColumn.BinaryOperations.cs 0.00% <0.00%> (ø)
...lysis/PrimitiveDataFrameColumn.BinaryOperations.cs 41.52% <100.00%> (+0.06%) ⬆️
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 81.39% <100.00%> (+0.52%) ⬆️
...Analysis/StringDataFrameColumn.BinaryOperations.cs 82.78% <100.00%> (+3.37%) ⬆️
...st/Microsoft.Data.Analysis.Tests/DataFrameTests.cs 99.28% <100.00%> (+0.01%) ⬆️

... and 9 files with indirect coverage changes

Copy link
Contributor

@JakeRadMSFT JakeRadMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some comments about using IsValid instead of the other ways of checking the value for null.

@ghost ghost added the needs-author-action label Jun 23, 2023
@JakeRadMSFT
Copy link
Contributor

Thanks @asmirnov82! Can you merge this into https://github.com/JakeRadMSFT/machinelearning/tree/u/jakerad/generic-math as well?

@ghost ghost removed the needs-author-action label Jul 6, 2023
@JakeRadMSFT
Copy link
Contributor

Merged into Generic Math branch!

@JakeRadMSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@JakeRadMSFT JakeRadMSFT merged commit 578d7bc into dotnet:main Jul 7, 2023
@asmirnov82 asmirnov82 deleted the 6110_unable_to_filter_by_null branch July 8, 2023 06:42
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrameColumn: Unable to Filter by Null via ElementWiseXYZ Methods (System.NotSupportedException)
2 participants