Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing implementation for datetime relevant arrow type into dataframe #6675

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Add missing implementation for datetime relevant arrow type into dataframe #6675

merged 7 commits into from
Jul 6, 2023

Conversation

asmirnov82
Copy link
Contributor

@asmirnov82 asmirnov82 commented May 12, 2023

Fixes #6201

Add support for converting Apache Arrow Date64 column into DataFrame DateTimePrimitiveColumn and vice versa

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #6675 (047d719) into main (184e661) will increase coverage by 0.01%.
The diff coverage is 82.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6675      +/-   ##
==========================================
+ Coverage   68.87%   68.88%   +0.01%     
==========================================
  Files        1216     1216              
  Lines      250915   250932      +17     
  Branches    26259    26267       +8     
==========================================
+ Hits       172825   172864      +39     
+ Misses      71265    71243      -22     
  Partials     6825     6825              
Flag Coverage Δ
Debug 68.88% <82.50%> (+0.01%) ⬆️
production 63.38% <81.57%> (+0.01%) ⬆️
test 88.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icrosoft.Data.Analysis/PrimitiveColumnContainer.cs 82.83% <ø> (-0.22%) ⬇️
...icrosoft.Data.Analysis/PrimitiveDataFrameColumn.cs 80.87% <76.66%> (-0.50%) ⬇️
src/Microsoft.Data.Analysis/DataFrame.Arrow.cs 98.46% <100.00%> (+0.08%) ⬆️
src/Microsoft.Data.Analysis/DataFrame.IO.cs 80.76% <100.00%> (ø)
...osoft.Data.Analysis.Tests/ArrowIntegrationTests.cs 100.00% <100.00%> (ø)
...Microsoft.Data.Analysis.Tests/DataFrame.IOTests.cs 98.97% <100.00%> (ø)

... and 10 files with indirect coverage changes

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for submitting this!

@michaelgsharp
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@JakeRadMSFT
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@JakeRadMSFT
Copy link
Contributor

JakeRadMSFT commented Jun 23, 2023

Merged into Generic Math branch. (This is just a note for myself)

@JakeRadMSFT JakeRadMSFT merged commit 443ceb9 into dotnet:main Jul 6, 2023
@asmirnov82 asmirnov82 deleted the 6201_add_support_for_arrow_date64 branch July 7, 2023 13:11
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing implementation for datetime relevant arrow types
3 participants