Object Detection using TorchSharp#6605
Merged
michaelgsharp merged 14 commits intodotnet:mainfrom Apr 26, 2023
Merged
Conversation
michaelgsharp
requested review from
JakeRadMSFT,
LittleLittleCloud,
luisquintanilla and
tannergooding
ghost
assigned
tarekgh
reviewed
Mar 22, 2023
JakeRadMSFT
reviewed
Mar 22, 2023
JakeRadMSFT
reviewed
Mar 22, 2023
ericstj
reviewed
Mar 22, 2023
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Small comments about index/range
JakeRadMSFT
reviewed
Mar 22, 2023
JakeRadMSFT
reviewed
Mar 22, 2023
JakeRadMSFT
reviewed
Mar 22, 2023
JakeRadMSFT
reviewed
Mar 22, 2023
src/Microsoft.ML.TorchSharp/AutoFormerV2/ObjectDetectionTrainer.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
+ Coverage 68.39% 68.52% +0.13%
==========================================
Files 1174 1200 +26
Lines 248047 250288 +2241
Branches 25909 26093 +184
==========================================
+ Hits 169647 171521 +1874
- Misses 71626 71932 +306
- Partials 6774 6835 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JakeRadMSFT
reviewed
Mar 28, 2023
ericstj
changed the title
ericstj
reviewed
Apr 3, 2023
ericstj
approved these changes
Apr 3, 2023
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
None of my feedback is blocking, it's all just cleanup. I'd like a review from other area experts before merging though.
JakeRadMSFT
reviewed
Apr 3, 2023
LittleLittleCloud
approved these changes
Apr 3, 2023
JakeRadMSFT
reviewed
Apr 25, 2023
src/Microsoft.ML.TorchSharp/AutoFormerV2/ObjectDetectionMetrics.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Jake <31937616+JakeRadMSFT@users.noreply.github.com>
JakeRadMSFT
reviewed
Apr 25, 2023
src/Microsoft.ML.TorchSharp/AutoFormerV2/ObjectDetectionMetrics.cs
Outdated
Show resolved
Hide resolved
JakeRadMSFT
approved these changes
Apr 25, 2023
luisquintanilla
approved these changes
Apr 25, 2023
Contributor
luisquintanilla
left a comment
luisquintanilla
left a comment
There was a problem hiding this comment.
LGTM. Thanks everyone for the work involved in making this happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in Object Detection using TorchSharp with an AutoFormer model.
Main files to look at are the Object Detection Trainer, Utility methods, and the refactors to TextClassification and Sentence Similarity.
We also pulled in local/internal copies of System.Range/Index to make the future model conversion process much easier.