-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Object Detection using TorchSharp #6605
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments about index/range
src/Microsoft.ML.TorchSharp/AutoFormerV2/ObjectDetectionTrainer.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6605 +/- ##
==========================================
+ Coverage 68.39% 68.52% +0.13%
==========================================
Files 1174 1200 +26
Lines 248047 250288 +2241
Branches 25909 26093 +184
==========================================
+ Hits 169647 171521 +1874
- Misses 71626 71932 +306
- Partials 6774 6835 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of my feedback is blocking, it's all just cleanup. I'd like a review from other area experts before merging though.
src/Microsoft.ML.TorchSharp/AutoFormerV2/ObjectDetectionMetrics.cs
Outdated
Show resolved
Hide resolved
…s.cs Co-authored-by: Jake <31937616+JakeRadMSFT@users.noreply.github.com>
src/Microsoft.ML.TorchSharp/AutoFormerV2/ObjectDetectionMetrics.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks everyone for the work involved in making this happen.
Adds in Object Detection using TorchSharp with an AutoFormer model.
Main files to look at are the Object Detection Trainer, Utility methods, and the refactors to TextClassification and Sentence Similarity.
We also pulled in local/internal copies of System.Range/Index to make the future model conversion process much easier.