-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RegressionExpeirment using AutoMLExperiment #6338
Improve RegressionExpeirment using AutoMLExperiment #6338
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6338 +/- ##
==========================================
+ Coverage 68.56% 68.64% +0.08%
==========================================
Files 1171 1171
Lines 247736 247964 +228
Branches 25733 25738 +5
==========================================
+ Hits 169858 170214 +356
+ Misses 71115 71008 -107
+ Partials 6763 6742 -21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[InlineData("en-US")] | ||
[InlineData("ar-SA")] | ||
[InlineData("pl-PL")] | ||
public void AutoFitRegressionTest(string culture) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer using SMac Sweeper in regression, so we can just remove this test.
@@ -159,7 +159,7 @@ public override ExperimentResult<MulticlassClassificationMetrics> Execute(IDataV | |||
// split cross validation result according to sample key as well. | |||
if (rowCount < crossValRowCountThreshold) | |||
{ | |||
const int numCrossValFolds = 10; | |||
int numCrossValFolds = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you have removed the const?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no specific reason of doing that. I just feel like there's no need to mark this numCrossValFolds
as const.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why you have a variable in the first place then? I mean why you don't just call the method and passing 10
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't notice that,, fixed and Resolved
// Else, run experiment using train-validate split. | ||
const int crossValRowCountThreshold = 15000; | ||
var rowCount = DatasetDimensionsUtil.CountRows(trainData, crossValRowCountThreshold); | ||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
module my minor questions, LGTM.
@@ -159,8 +159,7 @@ public override ExperimentResult<MulticlassClassificationMetrics> Execute(IDataV | |||
// split cross validation result according to sample key as well. | |||
if (rowCount < crossValRowCountThreshold) | |||
{ | |||
const int numCrossValFolds = 10; | |||
_experiment.SetDataset(trainData, numCrossValFolds); | |||
_experiment.SetDataset(trainData, 10); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: you may add the parameter name before 10
for code readability :-)
We are excited to review your PR.
So we can do the best job, please check:
There's a descriptive title that will make sense to other developers some time from now.
There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
You have included any necessary tests in the same PR.
AutoML.Net improvements tracking down list #6145
Update or deprecate AutoML 1.x APIs #6532