Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve multiclassification using AutoMLExperiment #6270

Merged

Conversation

LittleLittleCloud
Copy link
Contributor

@LittleLittleCloud LittleLittleCloud commented Aug 2, 2022

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.
  • Update or deprecate AutoML 1.x APIs #6532

@@ -8,6 +8,7 @@ public static void Main(string[] args)
{
try
{
Cifar10.Run();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to clear the console after this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@michaelgsharp
Copy link
Member

@LittleLittleCloud couple of questions, but it also looks like some tests are failing as well.

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #6270 (02c1c98) into main (61c347c) will increase coverage by 0.18%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main    #6270      +/-   ##
==========================================
+ Coverage   68.39%   68.58%   +0.18%     
==========================================
  Files        1144     1170      +26     
  Lines      244970   246892    +1922     
  Branches    25408    25666     +258     
==========================================
+ Hits       167551   169332    +1781     
- Misses      70764    70843      +79     
- Partials     6655     6717      +62     
Flag Coverage Δ
Debug 68.58% <28.57%> (+0.18%) ⬆️
production 63.06% <ø> (+0.21%) ⬆️
test 89.01% <28.57%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/Microsoft.ML.AutoML.Tests/AutoFitTests.cs 76.32% <28.57%> (-9.43%) ⬇️
...Microsoft.ML.TorchSharp/Utils/DefaultDictionary.cs 0.00% <0.00%> (-30.62%) ⬇️
...c/Microsoft.ML.FastTree/Utils/ThreadTaskManager.cs 79.48% <0.00%> (-20.52%) ⬇️
...luators/Metrics/MulticlassClassificationMetrics.cs 89.47% <0.00%> (-10.53%) ⬇️
test/Microsoft.ML.Tests/TextClassificationTests.cs 93.75% <0.00%> (-6.25%) ⬇️
src/Microsoft.ML.Data/TrainCatalog.cs 80.16% <0.00%> (-2.87%) ⬇️
test/Microsoft.ML.AutoML.Tests/DatasetUtil.cs 96.96% <0.00%> (-2.03%) ⬇️
.../Microsoft.ML.Vision/ImageClassificationTrainer.cs 92.13% <0.00%> (-0.12%) ⬇️
...ML.TorchSharp/NasBert/TextClassificationTrainer.cs 87.73% <0.00%> (-0.05%) ⬇️
... and 51 more

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@LittleLittleCloud
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

/// <summary>
/// See <see cref="AveragedPerceptronTrainer"/>.
/// </summary>
AveragedPerceptron,
Copy link
Member

@tarekgh tarekgh Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AveragedPerceptron

Is there any app-compat concern removing public stuff from here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API is still unstable so we can change it. But it will affect code that uses AveragePerceptron.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good if somehow document this breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this PR I add an api break change label to it so we can document it in the next release note.
And let me talk to Eric and Luis on how to document it.

@LittleLittleCloud LittleLittleCloud added the API breaking change The change(s) required for this issue may break the current API label Aug 17, 2022
@LittleLittleCloud LittleLittleCloud merged commit d75dd60 into dotnet:main Aug 17, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
API breaking change The change(s) required for this issue may break the current API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants