Added ADO.NET importing/exporting functionality to DataFrame #5975
Conversation
|
|
|
It seems that build fails because I added a reference to the System.Data.SQLite NuGet package (it's only used for integration tests), and the build doesn't use public NuGet repos; I wonder if it's possible to add System.Data.SQLite to the private repo? |
|
@andrei-faber I believe that should be just fine. Let me talk to some people on my end and I'll get back to you. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@andrei-faber The NuGet package has been added and I have requeued the pipelines. |
| @@ -1,6 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <NoWarn>$(NoWarn);MSML_ParameterLocalVarName;MSML_PrivateFieldName;MSML_ExtendBaseTestClass;MSML_GeneralName</NoWarn> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
There was a problem hiding this comment.
We don't need to specifically set the target framework here. It happens based on command line parameters and lets us set multiple different ones.
At some point I am going to change this to be multi-targeting, but at least for now we can just remove this.
| @@ -34,4 +35,8 @@ | |||
| <EmbeddedResource Include="../../src/Microsoft.Data.Analysis/Strings.resx" LogicalName="Microsoft.Data.Analysis.Strings.resources" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="System.Data.SQLite" Version="1.0.115" /> | |||
There was a problem hiding this comment.
Looks like the version that I was able to get added is 1.0.113.7. Do you need 1.0.115 specifically? Or can we use 1.0.113.7?
There was a problem hiding this comment.
@michaelgsharp it should work as well, but it seems that 1.0.113.7 is no longer available on nuget.org so I can't test it on my side.
Changed version of System.Data.SQLite
|
@michaelgsharp some strange version conflict in there. Maybe it's better to use libraries with the same version number for System.Data.SQLite.Core in Microsoft.ML.Tests.csproj and System.Data.SQLite in Microsoft.Data.Analysis.Tests.csproj |
|
@andrei-faber So part of the issue is that we are still building for .net core 2, which the sql package doesn't support. I am in the process of removing that, should be done by next week (have a couple of things do to first), that should resolve this issue. So we should be able to get this in next week. I did get the version stuff figured out, I didn't get the package moved correctly. |
|
@michaelgsharp great, thanks. Is there anything I can do to help? |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5975 +/- ##
==========================================
+ Coverage 68.65% 68.67% +0.01%
==========================================
Files 1202 1203 +1
Lines 250769 250974 +205
Branches 26190 26209 +19
==========================================
+ Hits 172166 172344 +178
- Misses 71785 71805 +20
- Partials 6818 6825 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ghost
locked as resolved and limited conversation to collaborators
See #5972
This universal integration with ADO.NET allows importing and exporting data to a large number of SQL-compatible databases.
In addition to this, this PR adds methods to load data from any IEnumerable collections and to export data to System.Data.DataTable